Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Next Release (TBD)
==================

* No changes yet.
* Reject slice expressions with multiple numbers in the same component.


1.1.0
Expand Down
2 changes: 1 addition & 1 deletion jmespath/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ def _parse_slice_expression(self):
self._raise_parse_error_for_token(
self._lookahead_token(0), 'syntax error')
self._advance()
elif current_token == 'number':
elif current_token == 'number' and parts[index] is None:
parts[index] = self._lookahead_token(0)['value']
self._advance()
else:
Expand Down
40 changes: 40 additions & 0 deletions tests/compliance/slice.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@
"expression": "foo[0:10:1]",
"result": [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
},
{
"expression": "foo[ 0 : 4 : 2 ]",
"result": [0, 2]
},
{
"expression": "foo[0:0:1]",
"result": []
},
{
"expression": "foo[0:10]",
"result": [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
Expand Down Expand Up @@ -118,6 +126,38 @@
"expression": "foo[8:2:0]",
"error": "invalid-value"
},
{
"expression": "foo[0:1 3]",
"error": "syntax"
},
{
"expression": "foo[0:1-2]",
"error": "syntax"
},
{
"expression": "foo[0:0 2]",
"error": "syntax"
},
{
"expression": "foo[::1 2]",
"error": "syntax"
},
{
"expression": "foo[::1-2]",
"error": "syntax"
},
{
"expression": "foo[::0 2]",
"error": "syntax"
},
{
"expression": "foo[0:1 3:2]",
"error": "syntax"
},
{
"expression": "[::1 2]",
"error": "syntax"
},
{
"expression": "foo[8:2:0:1]",
"error": "syntax"
Expand Down