Skip to content

Raise JMESPathTypeError from ceil()/floor() on infinity and NaN #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ApparentlyTejas wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Raise JMESPathTypeError from ceil()/floor() on infinity and NaN #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions jmespath/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,16 @@ def _func_reverse(self, arg):

@signature({"types": ['number']})
def _func_ceil(self, arg):
if math.isnan(arg) or math.isinf(arg):
raise exceptions.JMESPathTypeError(
'ceil', arg, 'non-finite number', ['number'])
return math.ceil(arg)

@signature({"types": ['number']})
def _func_floor(self, arg):
if math.isnan(arg) or math.isinf(arg):
raise exceptions.JMESPathTypeError(
'floor', arg, 'non-finite number', ['number'])
return math.floor(arg)

@signature({"types": ['string']}, {"types": ['array-string']})
Expand Down
22 changes: 22 additions & 0 deletions tests/test_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,25 @@ def test_variadic_is_pluralized(self):
self.assertEqual(
str(exception),
'Expected at least 1 argument for function not_null(), received 0')

def test_ceil_raises_jmespath_error_on_infinity(self):
# Regression test: ceil() used to pass its argument straight to
# math.ceil(), which raises the builtin OverflowError on infinity
# instead of a JMESPathError subclass.
with self.assertRaises(exceptions.JMESPathTypeError):
jmespath.search('ceil(@)', float('inf'))

def test_ceil_raises_jmespath_error_on_nan(self):
with self.assertRaises(exceptions.JMESPathTypeError):
jmespath.search('ceil(@)', float('nan'))

def test_floor_raises_jmespath_error_on_infinity(self):
# Regression test: floor() used to pass its argument straight to
# math.floor(), which raises the builtin OverflowError on infinity
# instead of a JMESPathError subclass.
with self.assertRaises(exceptions.JMESPathTypeError):
jmespath.search('floor(@)', float('inf'))

def test_floor_raises_jmespath_error_on_nan(self):
with self.assertRaises(exceptions.JMESPathTypeError):
jmespath.search('floor(@)', float('nan'))