Skip to content

Reject grouped and quoted function names #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Narek-Khachikyan wants to merge 1 commit into from
Closed

Reject grouped and quoted function names #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion jmespath/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,8 @@ def _token_led_and(self, left):
return ast.and_expression(left, right)

def _token_led_lparen(self, left):
if left['type'] != 'field':
if (left['type'] != 'field' or
self._lookahead(-2) != 'unquoted_identifier'):
# 0 - first func arg or closing paren.
# -1 - '(' token
# -2 - invalid function "name".
Expand Down
72 changes: 72 additions & 0 deletions tests/compliance/function_name_syntax.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
[
{
"given": {
"foo": 1,
"bar": 2,
"items": [
{
"foo": 2
},
{
"foo": 1
}
],
"length": "value"
},
"cases": [
{
"expression": "(length)(@)",
"error": "syntax"
},
{
"expression": "(\"length\")(@)",
"error": "syntax"
},
{
"expression": "((length))(@)",
"error": "syntax"
},
{
"expression": "((\"length\"))(@)",
"error": "syntax"
},
{
"expression": "to_array((length)(@))",
"error": "syntax"
},
{
"expression": "[(\"length\")(@)]",
"error": "syntax"
},
{
"expression": "\"length\"(@)",
"error": "syntax"
},
{
"expression": "length(@)",
"result": 4
},
{
"expression": "(length(@))",
"result": 4
},
{
"expression": "to_array(length(@))",
"result": [
4
]
},
{
"expression": "items[].length(@)",
"result": [
1,
1
]
},
{
"expression": "\"length\"",
"result": "value"
}
]
}
]