Repository navigation
Conversation
Filter holidays against both inclusive date boundaries and add regression tests for holidays outside and on the endpoints of the requested range. Generated-by: OpenAI Codex
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #724
Filter holidays against both inclusive date boundaries before subtracting them from the workday count.
Adds regression tests for holidays before, after, and surrounding the range, plus a check that holidays on the endpoints still count.
On Java 21,
mvn verifysucceeds: 806 tests reported, 57 skipped, no failures or errors. The three out-of-range regressions fail before the fix.AI assistance: OpenAI Codex wrote the fix and tests, ran validation, and drafted this description.