Repository navigation
feat: add field expression type helpers - #726
Open
JimmyLiuJia wants to merge 1 commit into
Open
JimmyLiuJia wants to merge 1 commit into
JimmyLiuJia wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspecting a cron field's expression type currently requires callers to check concrete expression classes. Add
FieldExpression.isAlways()andFieldExpression.isEvery()as convenient predicates for wildcard and step expressions, addressing #690.The predicates inspect the top-level expression type. Parsed
*/1is normalized toAlways, whereas a directly constructedEvery(1)remainsEveryeven though it renders as*. AnAndcontaining a step expression returns false for both predicates. Javadoc explains these boundaries and points callers toEvery.getPeriod()for the step value.Tests cover parsed wildcards, steps, ranges, fixed values and lists, plus
Every(1), a deserializedAlways,QuestionMark, and a custom expression subclass.Validation on JDK 17:
mvn -B -ntp clean verifypassed, including binary, source and Javadoc JAR generation. Surefire reported 814 tests, 0 failures, 0 errors and 57 skipped.FieldExpressionTest: 13 cases, 0 failures, 0 errors and 0 skipped.Fixes #690.
AI assistance: OpenAI Codex assisted with the implementation, tests and PR description.