Skip to content

Improve contact search logic for email matching #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SamuelPlentz wants to merge 1 commit into
base: Main
Choose a base branch
from
Open

Improve contact search logic for email matching #645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/modules/quicktextParser.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1227,7 +1227,23 @@ export class QuicktextParser {
includeRemote: false,
searchString: states['TO'].data['email'][aIndex].toLowerCase()
})
let card = cards.find(c => c.type == "contact");

let email = states['TO'].data['email'][aIndex].toLowerCase();

// Prefer an exact email address match.
// Thunderbird's quickSearch() may return contacts with similar email addresses, so using the first result can select the wrong contact.
let card = cards.find(c =>
c.type == "contact" &&
(
c.properties.PrimaryEmail?.toLowerCase() == email ||
c.properties.SecondEmail?.toLowerCase() == email
)
);

// Fall back to the previous behavior if no exact match is available.
if (!card) {
card = cards.find(c => c.type == "contact");
}

if (card != null) {
// Get directly stored props first.
Expand Down