Repository navigation
Numerically stable false alarm probability for Lomb Scargle #14
Description
Current implementation of fap_baluev is numerically unstable and will return 0 when FAP is small enough. There should be a way to obtain a numerically stable implementation (perhaps using a log(-log(FAP)) transform or something).
Activity
LS: batched_run_const_nfreq returns the Baluev FAP of the best peak w…
johnh2o2 commentedon Sep 28, 2026
Release triage for PR #69 (cuvarbase 1.0.1, source
6b6c48945160).This issue is implemented in PR #69 and will close automatically when that PR merges into master. Keeping it open until the merge.
The cancellation-prone subtraction is replaced with log-space evaluation and expm1. The existing host validation passed all five FAP regression tests, including significant peaks and agreement at moderate powers. Positive probabilities are retained down to representable float64 values; this does not promise values below the floating-point limit.
Evidence: log-space/expm1 implementation · FAP regression tests