Repository navigation
Preserve datatype palettes and scope accessibility styling to high contrast - #114
Closed
jonaraphael wants to merge 7 commits into
Closed
jonaraphael wants to merge 7 commits into
jonaraphael wants to merge 7 commits into
Conversation
jonaraphael
force-pushed
the
codex/fix-high-contrast
branch
from
October 17, 2026 04:19
351b378 to
1a3d74d
Compare
jonaraphael
marked this pull request as ready for review
October 17, 2026 04:26
This was referenced Oct 17, 2026
jonaraphael
marked this pull request as draft
October 17, 2026 05:02
This was referenced Oct 17, 2026
jonaraphael
marked this pull request as ready for review
October 17, 2026 14:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dark High Contrast was classified as a light theme, so CSV used its light datatype palette on a dark background. This change classifies it correctly while preserving the user's selected
default,cool, orwarmdatatype palette. Both high-contrast variants continue to honorcsv.columnColorMode: datatype colors remain the default, and theme foreground remains an explicit local choice. No settings or commands are added.The accessibility stylesheet applies only to high-contrast body classes. It adds theme-aware borders, menus, Find/Replace controls and selection/find outlines without forcing cell foregrounds or covering datatype colors with selection fills. Ordinary light/dark colors retain their previous values. Inherited color variables allow theme transitions without replacing the webview, cell DOM, draft, focus or caret. The palette calculation itself is unchanged.
Addresses #92.
Validation:
npm run compile,npm test— all 173 tests pass;npm run lint— 0 errors, 87 existing warnings;git diff --checkpasses.Independent orchestrator review and integration: inspected the final delta and both renderer conflict resolutions. The combined candidate
8b2860epasses compile, all 529 tests, lint (0 errors; 86 existing warnings) and diff checks. Chromium checks cover frozen selection and actual Find matches, all four theme transitions, numeric/date/boolean filtered source identities, and live/deferred multiline edits. Frozen offsets, filter-bar inset, serial/header actions, popup geometry, arrow scrolling and existing draft guards remain intact.Exact-head GitHub CI succeeds and this PR is mergeable against its current stacked base. The narrowed palette policy is cleared for human review; no merge or release has been performed.