Repository navigation
Add header and serial index actions and keep context menus in view - #124
Closed
jonaraphael wants to merge 11 commits into
Closed
jonaraphael wants to merge 11 commits into
jonaraphael wants to merge 11 commits into
Conversation
jonaraphael
marked this pull request as ready for review
October 17, 2026 05:32
jonaraphael
marked this pull request as draft
October 17, 2026 06:52
jonaraphael
marked this pull request as ready for review
October 17, 2026 07:00
jonaraphael
marked this pull request as draft
October 17, 2026 07:11
jonaraphael
marked this pull request as ready for review
October 17, 2026 07:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSV's per-file header and serial index preferences are only available through the Command Palette. Context menus now offer them where they apply:
Both actions use the existing preference for the owning document and refresh that file's views without changing CSV text or saving. Messages validate boolean values; repeated serial-state requests are no-ops. The serial action maps a disappearing index/corner anchor to a surviving data cell in the same source row (corner: first visible row), preserving an existing valid data anchor. The live anchor is updated before persistence so later blur/refresh persistence cannot restore a missing serial cell. Scroll state is preserved. Header actions retain effective detected/explicit state, including empty files, and tag-independent anchor restoration when data becomes a header.
Menus measure their completed contents before opening. They use available viewport space to open left or upward when the right or bottom side cannot fit, then clamp within editor margins. Natural width is preserved when space permits; narrow or short panes wrap and scroll the menu so actions remain reachable. Placement uses viewport coordinates even when the table or document is scrolled. Viewport resize and actual CSV zoom changes dismiss an open menu; reopening measures it again. No settings, command contributions, palette or theme-color changes are added.
Depends on #111. Combined integration also uses the existing shared draft-safe refresh path from the editor-switch/untitled work. The shared clipboard path quotes each value only as required and omits the extra append row from all Copy/Cut routes, while preserving real empty source cells.
Validation:
First row, headers disabled:
First row, headers enabled:
Later rows:
Right-edge placement in the combined browser fixture:
Serial index context action in the combined browser fixture: