Repository navigation
fix: secure terminal echo and package verification - #96
Merged
Merged
Conversation
A shared workspace target can reuse an older bin test executable. Build each extracted consumer in a fresh target directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Reopen saved terminals without following links. Check the opened fd's type,
owner, permissions, and terminal status before writing. Keep echo nonblocking
and leave terminal settings alone.
Echo only the last 8 KiB of each stream, strip controls except newline and tab,
and cap the resulting UTF-8 text at 8 KiB too. Raw capture files and run outcomes
stay unchanged. Tests use owned PTYs and cover unsafe paths, permissions,
unavailable devices, Unicode, malformed bytes, and truncation.
Build extracted source-package tests in a fresh target directory. A shared
workspace target had reused an older test binary despite the new archive's
matching source. The scripts guide now warns against sharing that target.
Checks
scripts/check.sh full: 545 tests, format/build/Clippy, actual Rust 1.85,rustdoc, dependency checks, Markdown, offline links, package policy, and publish
dry run passed.
645e5a8, outside the workspace, using actual Rust 1.85and a fresh consumer target: 454 bin tests passed, including all eight terminal
tests. Archive VCS metadata and extracted source match the candidate.
harness, and scripts-guide lint passed.
All required and additional current-head checks must pass before merge.
No publication, tags, repository settings, or branch cleanup.