Repository navigation
ci(memory-plugin): install host openclaw from node-tools lock - #250
Merged
Merged
Conversation
The vendored memory-plugin host lane ran `npm install openclaw@<pin>` into a temp prefix, so every transitive dependency floated and the lane could hit ETARGET on freshly published packages, the flake class the node-tools lock already fixed for bootstrap. - Install the committed platform/node-tools manifest+lock with the same `npm ci` + transient-retry + `--version` smoke path bootstrap uses; the version now comes from the manifest, so `--package-spec` and the hardcoded pin in the workflow are gone. - Route node-tools lock/module changes to the memory_plugin CI lane and key the setup-node npm cache on the node-tools lock too. - Add a repo contract that scans workflow YAML and CI helper Python for resolving `npm install|i|add` (except --package-lock-only) and for `npx`/`npm exec` of openclaw/acpx. The strongclaw-hypermemory host check needs no change: it has no dependencies and uses a local plugin SDK stub, and `npm run` installs nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #239. The vendored memory-plugin host lane still installed OpenClaw with a floating
npm install, so every transitive dependency resolved at CI time, the same ETARGET flake class #239 fixed for bootstrap.Changes
run_vendored_host_checksnow installs the committedplatform/node-toolsmanifest+lock throughinstall_locked_node_tools. That helper reusesclawops.strongclaw_node_tools(load_node_tools_bundle,stage_node_tools_tree,smoke_test_node_tools), so it gets the samenpm ci --omit=dev, transient-only retry and--versionsmoke that bootstrap uses.NodeToolsErrorsurfaces asCiWorkflowError.--package-spec,DEFAULT_OPENCLAW_PACKAGE_SPECand the hardcodedopenclaw@2026.3.13in the workflow are removed.ci-gate-filters.yml:platform/node-tools/**, its packaged mirror andstrongclaw_node_tools.pynow route to thememory_pluginlane, because that lane consumes them now.setup-nodenpm cache key now includes the node-tools lock.test_ci_never_installs_node_packages_outside_a_lock(helpertests/utils/helpers/ci_node_installs.py). It scans.github/**YAML (parsed, so foldedrun: >-scalars are covered) and the CI Python entrypoints/helpers (string literals plus argv list/tuple literals). It flags any resolvingnpm install|i|add|...except--package-lock-only, and anynpx/npm execof openclaw/acpx. It flags all resolving installs because CI often passes the spec through a variable. Verified it fires on the pre-fix helper.The
strongclaw-hypermemoryhost check (npm --prefix ... run test:openclaw-host) needed no change. It has no dependencies, it uses a local plugin SDK stub, andnpm runinstalls nothing.Install command
npm install --prefix <tmp> --no-fund --no-audit openclaw@2026.3.13platform/node-tools/{package.json,package-lock.json}into<tmp>, thennpm ci --omit=dev --no-audit --no-fund, thenopenclaw --version/acpx --versionsmokeVerification
make lint,make imports,make typecheck(mypy + pyright 0 errors),make actionlint: passmake test-unit: 1185 passedmake test-contracts: 149 passedOpenClaw 2026.3.13 (61d171a),acpx 0.3.0