Skip to content

ci(memory-plugin): install host openclaw from node-tools lock - #250

Merged
jsugg merged 1 commit into
mainfrom
ci/lock-plugin-host-openclaw
Nov 11, 2026
Merged

jsugg merged 1 commit into
mainfrom
ci/lock-plugin-host-openclaw

Conversation

@jsugg

@jsugg jsugg commented Nov 11, 2026

Copy link
Copy Markdown
Owner

Summary

Follow-up to #239. The vendored memory-plugin host lane still installed OpenClaw with a floating npm install, so every transitive dependency resolved at CI time, the same ETARGET flake class #239 fixed for bootstrap.

Changes

  • run_vendored_host_checks now installs the committed platform/node-tools manifest+lock through install_locked_node_tools. That helper reuses clawops.strongclaw_node_tools (load_node_tools_bundle, stage_node_tools_tree, smoke_test_node_tools), so it gets the same npm ci --omit=dev, transient-only retry and --version smoke that bootstrap uses. NodeToolsError surfaces as CiWorkflowError.
  • The version comes from the manifest: --package-spec, DEFAULT_OPENCLAW_PACKAGE_SPEC and the hardcoded openclaw@2026.3.13 in the workflow are removed.
  • ci-gate-filters.yml: platform/node-tools/**, its packaged mirror and strongclaw_node_tools.py now route to the memory_plugin lane, because that lane consumes them now.
  • setup-node npm cache key now includes the node-tools lock.
  • New contract test_ci_never_installs_node_packages_outside_a_lock (helper tests/utils/helpers/ci_node_installs.py). It scans .github/** YAML (parsed, so folded run: >- scalars are covered) and the CI Python entrypoints/helpers (string literals plus argv list/tuple literals). It flags any resolving npm install|i|add|... except --package-lock-only, and any npx/npm exec of openclaw/acpx. It flags all resolving installs because CI often passes the spec through a variable. Verified it fires on the pre-fix helper.

The strongclaw-hypermemory host check (npm --prefix ... run test:openclaw-host) needed no change. It has no dependencies, it uses a local plugin SDK stub, and npm run installs nothing.

Install command

  • Before: npm install --prefix <tmp> --no-fund --no-audit openclaw@2026.3.13
  • After: copy platform/node-tools/{package.json,package-lock.json} into <tmp>, then npm ci --omit=dev --no-audit --no-fund, then openclaw --version / acpx --version smoke

Verification

  • make lint, make imports, make typecheck (mypy + pyright 0 errors), make actionlint: pass
  • make test-unit: 1185 passed
  • make test-contracts: 149 passed
  • Real locked install run locally: OpenClaw 2026.3.13 (61d171a), acpx 0.3.0

The vendored memory-plugin host lane ran `npm install openclaw@<pin>`
into a temp prefix, so every transitive dependency floated and the lane
could hit ETARGET on freshly published packages, the flake class the
node-tools lock already fixed for bootstrap.

- Install the committed platform/node-tools manifest+lock with the same
  `npm ci` + transient-retry + `--version` smoke path bootstrap uses;
  the version now comes from the manifest, so `--package-spec` and the
  hardcoded pin in the workflow are gone.
- Route node-tools lock/module changes to the memory_plugin CI lane and
  key the setup-node npm cache on the node-tools lock too.
- Add a repo contract that scans workflow YAML and CI helper Python for
  resolving `npm install|i|add` (except --package-lock-only) and for
  `npx`/`npm exec` of openclaw/acpx.

The strongclaw-hypermemory host check needs no change: it has no
dependencies and uses a local plugin SDK stub, and `npm run` installs
nothing.
@jsugg
jsugg merged commit 6e99f35 into main Nov 11, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant