Add exact Newton policies and resident CUDA foundation recipes - #27
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9de2c9bc34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,19 @@ | |||
| { | |||
| "schema": "openboost-pr27-modal-validation-index-v1", | |||
| "source_commit": "312d8213900c0e4b35e7bdcac3d92d74ca5dbb81", | |||
There was a problem hiding this comment.
Keep the validation source commit reachable after squash merge
After this PR is squash-merged as a059cd4, the recorded 312d821... commit is not an ancestor of the resulting commit and exists only in the checkpoint branch. check_modal_validation.py calls git ls-tree on this SHA, so a fresh checkout cannot run either main workflow once that branch is deleted or no longer advertised, even though the validated non-evidence inventory matches. Retain the source commit through main or a permanent tag, or verify the committed inventory without requiring this otherwise-unreachable object.
AGENTS.md reference: AGENTS.md:L15-L18
Useful? React with 👍 / 👎.
Bring the foundation checkpoint onto public main: explicit CUDA multiclass, AFT and multi-output recipes; exact Newton ordering and Normal split/leaf policies; resident input sharing; compatible scalar squared scheduling; and accompanying CPU components, reference tests and documentation.
Production sources match the retained
91a519dcheckpoint. The selection manifest records source/test provenance and omitted archive-dependent tests. The compact historical train-many report remains a limited historical observation; fresh validation of this candidate is recorded separately.Validation at
312d8213900c0e4b35e7bdcac3d92d74ca5dbb81:Committed Modal receipts retain exact source inventories, installed wheel identities, original collections/JUnit, raw artifacts and earlier failed attempts. GitHub checks these bindings; numerical tests and builds execute on Modal. The results directory is the only exclusion from the tested tracked-source inventory.
This remains an experimental foundation checkpoint. CPU shared-tree and CUDA independent-tree multiclass are distinct recipes. Full-budget Housing and later classification construction are outside this PR; omitted archive-dependent tests remain recorded obligations. Full v1, application quality/cost acceptance and E5 remain open; E5 is deferred.