Repository navigation
Conversation
Signed-off-by: hd <63141252+hnrydvd@users.noreply.github.com>
brandond
approved these changes
Nov 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The CLI docs give the default
--etcd-snapshot-diras${data-dir}/db/snapshots. The actual default is${data-dir}/server/db/snapshots, which is what the examples further downetcd-snapshot.mdalready show (/var/lib/rancher/k3s/server/db/snapshots).Change
docs/cli/etcd-snapshot.md: fix the default in the scheduled and on-demand flag tables.docs/cli/server.md: fix the default in the Database table and the matching line of thek3s server --helpblock.Verification
Checked against k3s
main(3461a87):pkg/etcd/snapshot.go#L71-L72:defaultSnapshotPathjoins the controlDataDirwithdb/snapshots.pkg/server/server.go#L46-L48: the controlDataDiris<data-dir>/server.${data-dir}/server/db/snapshots:pkg/cli/cmds/server.go#L432,pkg/cli/cmds/etcd_snapshot.go#L45. Same in v1.37.1+k3s1 and the v1.33+ release lines.The Japanese and Chinese translations have the same old path; I left those alone and can follow up if that's useful.
I used Claude Code to help find this and make the edit; I checked the source references above myself.