Repository navigation
Address review feedback for startup account and window creation - #47
Closed
matheuscardosoj wants to merge 1 commit into
Closed
matheuscardosoj wants to merge 1 commit into
matheuscardosoj wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Addresses the maintainer feedback that is not already present in
master:The current
masteralready includes the asynchronous account-management commands and idempotent autostart disablement, so they are intentionally absent from this focused diff.Closes and replaces #26 after its head branch was renamed in the fork.
Validation
cargo test --manifest-path src-tauri/Cargo.toml --locked— 102 passed.cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets -- -D warnings -A unused_mutpassed.unused_mutis a pre-existing Windows-only warning inmaster.git diff --checkpassed.