feat: 文字・本文・入力・重なるものの部品 10 個と、軸 96〜102 の決定 - #18
Merged
Merged
Conversation
…iew axes 96–102 Add Mark, Time, RelativeTime, NumberFormat, Accordion, AlertDialog, Textarea, SkipLink, Bleed and CopyButton, and give Button an icon-only shape (square by default, round selectable). ThemeProvider now passes locale and time zone defaults. Shared parts move to src/internal: collapsible styles, scroll area styles, copy parts, date helpers and the mark styles that Prose and Mark share. Field gains an invalid state without a message line, used by Textarea when maxCount is exceeded. The comparison stories for axes 96–102 are kept in this commit as the point of decision; they are removed in the next commit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Write ADR-0121 (Mark, Time, RelativeTime, NumberFormat and the locale and time zone defaults) and ADR-0122–0128 for Accordion, AlertDialog, Textarea, SkipLink, Bleed, the icon-only button shape and CopyButton, with comparison images. Note in ADR-0102 that AlertDialog is now a component. Update principles 1, 4 and 5, the backlog, the ADR index and the visual testing notes, and remove the comparison stories (decided at 2f37f7f). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
README の未実装のうち、デザインと部品がそろっていたものを作りました。決まっていなかった見た目は Design Review(軸 96〜102)で決め、ADR-0121〜0128 に記録しています。
足した部品
locale・timeZoneで上書きできますmaxCountによる文字数の上限)iconOnlyとshape(ADR-0127)共有に移したもの(見た目は変えていません)
src/internal/: collapsible-styles・scroll-area-styles・copy(use-copy とコピーの印)・date(日付の書式・今・言語)・reading/markinvalid(エラーの行なしでエラーの状態にする)を足しましたコミット
2f37f7f部品と比較ストーリー(決めた時点。git checkout 2f37f7f && pnpm storybookで比較を開けます)6af0b83ADR・原則・backlog・索引・比較画像の記録と、比較ストーリーの削除README には、部品の一覧を広げた変更(メインの作業ツリーで未コミットだったもの)も含まれています。
確かめたこと
pnpm typecheck・pnpm lint(既存の警告 2 件のみ)・pnpm format:checkpnpm test: 61 ファイル・281 件すべて通過。コミット済みの基準画像は 1 枚も変わっていませんあとで見ること(backlog に記載)
🤖 Generated with Claude Code