Skip to content

Keep the bank's fee and VAT when a requery reply leaves them out - #12

Merged
kenzycodex merged 1 commit into
mainfrom
fix/bank-charges
Nov 11, 2026
Merged

kenzycodex merged 1 commit into
mainfrom
fix/bank-charges

Conversation

@kenzycodex

@kenzycodex kenzycodex commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

A real ₦5,000 transfer on the cluster settled as Paid, but the result screen showed no fee or VAT. The bank's transfer record has them (fee 10.00, VAT 0.75, total 5,010.75); the requery reply carries the status only, and we wrote its missing charges over the stored ones.

  • On a final state with no charges in the reply, read them from GET /transfers/{reference}
  • Missing charges never overwrite recorded ones (requery and webhook paths)
  • Test reproduces the sandbox's reply shape; API suite 455 passed, ruff clean

The sandbox's requery reply carries the status only, which blanked the
charges on the result screen. Read them from the transfer record instead,
and never overwrite recorded charges with missing ones.
@kenzycodex
kenzycodex merged commit 2c3325e into main Nov 11, 2026
0 of 4 checks passed
@kenzycodex
kenzycodex deleted the fix/bank-charges branch November 11, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant