Repository navigation
fix(math): preserve arguments during heuristic removal - #426
Closed
RovshanMuradov wants to merge 1 commit into
Closed
RovshanMuradov wants to merge 1 commit into
RovshanMuradov wants to merge 1 commit into
Conversation
RovshanMuradov
marked this pull request as ready for review
October 12, 2026 07:28
RovshanMuradov
marked this pull request as draft
October 12, 2026 08:30
Contributor
Author
|
Closing to keep the review queue small: on six real arXiv HTML papers (~10k formulas) this change makes no difference to the extracted HTML or Markdown. Happy to reopen if a real page needs it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #421
Removal heuristics deleted MathML arguments: invisible boxes (
visibility:hidden,opacity:0,.invisible, e.g.mphantom) and elements matching page-chrome selectors, which leaves e.g.<mfrac>with one child. MathML arguments are now skipped by these heuristics;display:none,[hidden]andaria-hiddenstill remove them.