Repository navigation
Keep content containers that carry a data-date attribute - #442
Open
Hor1zonZzz wants to merge 1 commit into
Open
Hor1zonZzz wants to merge 1 commit into
Hor1zonZzz wants to merge 1 commit into
Conversation
Author
|
Repro with a live page and test runs, for review. Live page: https://felixrieseberg.com/how-to-be-more-ambitious-a-tutorial-for-humans-with-models/ (Ghost theme,
The extra output after the fix is the article body only; no author box, navigation or player controls come back, since every other exact selector still applies. Tests Website dependencies were installed for both runs. Main was tested at
The failures were 30-second timeouts in
No new failures were observed. The differing timeout counts should not be interpreted as fixes from this selector change.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #441.
[data-date]removed any element with the attribute, including a post body wrapper (seen on a Ghost site with a custom theme), which left an empty article. The rule now skips elements that contain at least two paragraphs, following the existingheader:not(:has(p + p))rule. Date badges are still removed.selectors--data-date-content-container(anonymized): empty content before this change; four paragraphs after it, and its date badge is still removed.