Separate live and restart configure paths - #342
Open
rgarcia wants to merge 3 commits into
Open
Conversation
rgarcia
force-pushed
the
hypeship/configure-path-refactor
branch
2 times, most recently
from
August 19, 2026 18:28
d6fb2b8 to
82cfb36
Compare
rgarcia
force-pushed
the
hypeship/configure-path-refactor
branch
from
August 19, 2026 19:10
82cfb36 to
f6f5874
Compare
rgarcia
force-pushed
the
hypeship/configure-path-refactor
branch
from
August 19, 2026 19:14
f6f5874 to
147da27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/chromium/configureas explicit live and restart execution modesstart_url-only requestsTesting
go vet ./...go test -race ./cmd/api/api -count=1go test -v -race -timeout 15m ./e2e -run '^TestChromiumConfigureMultipartPowerset$' -count=1images/chromium-headless/image/Dockerfilelocally for the e2e runThe full non-e2e race suite was also attempted. All packages passed except the existing
lib/devtoolsproxyrestart test, which failed duringt.TempDircleanup because Chromium was still writing its profile directory; rerunning that package reproduced the same cleanup failure.Note
Medium Risk
Touches Chromium lifecycle, display/recording coordination, and configure error recovery—behavior-preserving refactor but operationally sensitive.
Overview
/chromium/configureis refactored around explicit live vs restart execution modes instead of a single inlineneedsStopbranch.ChromiumConfiguredispatches viachromiumConfigureModeFor(replacingchromiumNeedsStopCycle) intochromiumConfigureLive(display patch + optionalstart_urlwithout stopping Chromium) andchromiumConfigureRestart(stop/apply/start). Shared navigation moves tochromiumConfigureNavigate.On the restart path, recording segment resume is centralized: segments restart after successful navigation on the happy path, and in a
deferon errors (before Chromium recovery) instead of only via a display-stepdefer.Unit tests cover mode selection and actionables; the configure powerset e2e adds
start_urlcases and asserts browser WebSocket identity is preserved on live configures and changes on policy/flags/extension restart paths.Reviewed by Cursor Bugbot for commit e7753a2. Bugbot is set up for automated code reviews on this repo. Configure here.