Repository navigation
Fix test-coverage: update codecov-action to v7 and don't fail on upload errors - #40
Merged
Merged
Conversation
codecov-action v6.0.0 imports Codecov's signing key from Keybase, which returns invalid OpenPGP data, so the CLI signature check fails and every push to master fails test-coverage (codecov/codecov-action#1955). Pin the v7 SHA used by the current r-lib/actions example.
kestrel99
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-coverage has failed on every push to master even though the tests pass (226/0). Two causes in the Codecov upload step:
Could not verify signature(GPG public key import returns invalid OpenPGP data, blocking Codecov uploads codecov/codecov-action#1955). Fixed by pinning v7 (fb8b358), matching the current r-lib/actions example; this run verified the CLI successfully.CODECOV_TOKENsecret is set (Token required because branch is protected). This setsfail_ci_if_error: falseso upload problems no longer fail the job.Note: until a token is added, coverage is still not reaching codecov.io (the README badge will be stale).