Repository navigation
Conversation
kim-em
force-pushed
the
perf/perm-group-small-certificates
branch
from
October 6, 2026 14:17
f142e5b to
f4989bf
Compare
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
kim-em
force-pushed
the
perf/perm-group-one-phase
branch
from
October 6, 2026 16:01
2ef6190 to
f2f75f3
Compare
kim-em
changed the base branch from
perf/perm-group-small-certificates
to
main
October 6, 2026 16:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR speeds up compiled Schreier-Sims in HexPermGroup by 3 to 50 times.
Group.ofGeneratorson the Rubik's cube group drops from 639 ms to 37 ms, and on Co3 from 2.6 s to 49 ms, now 1.3 to 24 times slower than GAP on the groups measured.Build.buildnow keeps the chain built by extension during the first level's scan as the suffix, instead of constructing each level's suffix a second time; it iscompletestarted from the trivial suffix, likeBuild.empty.Kernel.certifybuilds its own chain since #10814 "perf: smaller perm_group certificates without inverse generators", so stored chains no longer need their lower generators to be Schreier generators. The budgeted builder follows, and the hand-derived C₂ work counts inconformance/HexPermGroup/Limits.leanreturn to a single trivial suffix.OrbitgainsinvsandidReps, with default values and default proofs ofinvs_eqandidReps_eq, so existing constructors are unchanged.@[csimp]replacements ofChain.siftandOrbit.schreiermultiply by the stored inverses and skip identity representatives; the fields' equations make them equal to the definitions on every chain. One conformance example that built a corrupted orbit with{ swapOrbit with reps := … }now writes the orbit out, so its stored inverses are recomputed.Fixtures from
hexpermgroup_emit_fixturesare unchanged and all HexPermGroup bench hashes match.reports/20261006-perm-group-compiled-speedups.mdrecords before and after timings against GAP.🤖 Prepared with Claude Code