Repository navigation
Reclaiming duplicates updates the view in place; trash is never searched (0.10.2) - #16
Merged
Merged
Conversation
…hed (0.10.2) - After a real reclaim the duplicate view searched the whole drive again. It now stays where it was: reclaim_dupes handles one copy at a time and returns exactly which copies were deleted, trashed or hard-linked (`done`); the view drops those, removes groups left with a single file and recounts what each wastes (dropReclaimed, with a test). Open scans have the files taken out of their trees as before. The status says that trashed space is freed only when the Recycle Bin is emptied. - That new search also listed the copies just sent to the Recycle Bin as duplicates again: the bin is a folder on the same drive. Duplicate searches now never enter trash folders below their root ($Recycle.Bin, RECYCLER, System Volume Information, .Trash, .Trashes, .Trash-*; core TRASH_DIRS, so the CLI too). Searching inside the bin itself still works. Test included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now stays where it was: reclaim_dupes handles one copy at a time and returns
exactly which copies were deleted, trashed or hard-linked (
done); the viewdrops those, removes groups left with a single file and recounts what each
wastes (dropReclaimed, with a test). Open scans have the files taken out of
their trees as before. The status says that trashed space is freed only
when the Recycle Bin is emptied.
duplicates again: the bin is a folder on the same drive. Duplicate searches
now never enter trash folders below their root ($Recycle.Bin, RECYCLER,
System Volume Information, .Trash, .Trashes, .Trash-*; core TRASH_DIRS, so
the CLI too). Searching inside the bin itself still works. Test included.