Repository navigation
KNO-16683: Secure GitHub Actions - #44
Merged
cjbell merged 2 commits intoNov 6, 2026
Merged
Conversation
Co-authored-by: chris <chris@knock.app>
cjbell
requested review from
MikeCarbone and
thomaswhyyou
and removed request for
a team
November 6, 2026 15:27
thomaswhyyou
approved these changes
Nov 6, 2026
MikeCarbone
approved these changes
Nov 6, 2026
Co-authored-by: chris <chris@knock.app>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Linear: KNO-16683 (sub-issue of KNO-16655). Workflow-only changes; no version bumps.
Changes
actions/checkoutv7.0.1,actions/setup-javav6.1.0,gradle/actions/setup-gradlev6.4.1). These are the commits the existing floating tags (v7,v6,v6) point to, so there is no version change. Each SHA was checked against the upstream repo's own tags, and none of the three repos is a fork. There are no local composite actions.permissions: contents: readtoci.ymlandrelease-doctor.yml.publish-sonatype.yml: top-levelpermissions: {}, withcontents: readgranted only on thepublishjob. The job needs no write access. Secrets stay scoped to the publish step, and the publish steps and release tag/version guard (release: 2.0.0 #43) are unchanged.persist-credentials: falseto every checkout, since no job pushes to git.concurrencywith cancel-in-progress toci.ymlandrelease-doctor.yml. Their groups are per-ref and per-head-ref, so only superseded runs are cancelled.publish-sonatype.ymlhas no concurrency, so releases are never cancelled.pull_request_targettriggers and no piped installers. The onegithub.event.*value used inrun:(release.tag_name) already goes through anenv:variable. Therun:steps only call repo scripts.ci-secure
permissions:or unpinned actions, so the manual changes above are what fixed those.ci-score
pinned-action-shas(0/10 to all pinned),concurrency-groups,cancel-superseded.test-shardingis not worthwhile for one small Gradle test job.path-filterapplies torelease-doctor, which must run on every release PR. A path filter could skip a required check.Stainless-managed files
The repo started as Stainless output, and
ci.yml,publish-sonatype.ymlandrelease-doctor.ymlmatch the Stainless-generated templates. These edits may be overwritten on regeneration, so the same changes should go into the Stainless generator config or templates.Not committed
The skill files that
npx skills addcreated (.agents/,skills-lock.json) are not committed.CI on this PR will verify that the jobs still pass with read-only permissions.