Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
👷 Deploy request for kobalte pending review.Visit the deploys page to approve it
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #757
Select.Triggeronly checkeddisabled, so a read-only select still opened from a press or a key, andArrowLeft,ArrowRightand type-ahead still changed its value.This adds a read-only check to the trigger's pointer, click and key handlers, and updates the
readOnlyline of the docs.Comboboxdisables its trigger button for this, but it keeps its input focusable. Here the trigger is the only focus target, so it stays enabled and a keyboard user can still reach it.This covers input on the trigger only. A list opened through
openordefaultOpen, the remove and clear functions ofSelect.Value, and browser autofill through the hidden<select>can still change the value.The tests are in a new file because the suite in
select.test.tsxis skipped. Without the change, 9 of its 19 cases fail: every read-only case except the one that checks the trigger stays focusable.I also ran it in headless Chromium 141 with real mouse, touch and keyboard input. Without the change a press, a tap,
Enter,Space,ArrowDownandArrowUpopen a read-only select, andArrowLeft,ArrowRightandtchange its value. With it, the first six leave it closed, the last three leave its value atTwo, andTabstill reaches the trigger. An editable select gave the same results with and without the change.On Linux with Node 24 the new file passes. The core suite fails intermittently with and without this change: in
toggle-groupon both sides, and also inaria-hide-outsideandtoastwithout it.The same trigger code is on
solid2. I can open a port there if you want one.