Repository navigation
fix(local-execute): always load gateway-fetch shim for secret placeholders - #24
Merged
Merged
Conversation
…lders
Always call package-graph (even with no kody:@ imports) and side-effect import the origin-supplied .__kody_virtual__/runtime.js shim before user code so ambient Bearer {{secret:…}} fetch hops through gatewayFetch instead of leaving workerd raw (kentcdodds/kody#3020).
|
🎉 This PR is included in version 1.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Match kentcdodds/kody#3020: ad-hoc
execute --localscripts with nokody:@imports must still load the origin gateway-fetch shim so{{secret:…}}placeholders expand (or fail closed) instead of leaving workerd raw.Summary
POST /v1/local-execute/package-graph(remove the empty-imports early return)..__kody_virtual__/runtime.jsfrom the local workerd entry when origin returns it.Companion platform PR: closes the early return in
local-execute-package-graph.ts(kentcdodds/kody#3020).Testing
npm test(146 passed)npm run typecheck