Repository navigation
Fix the na:i tag in --details output and update CONTRIBUTING.md - #659
Open
NicolasBuchin wants to merge 2 commits into
Open
NicolasBuchin wants to merge 2 commits into
NicolasBuchin wants to merge 2 commits into
Conversation
The tag was printing 0 because the Details that go into the SAM records were never given the chain details. This is fixed now.
Removes mentions of NAMs and update `--max-seed-length` to `-m`.
NicolasBuchin
marked this pull request as ready for review
October 14, 2026 10:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at the details output when I realized it always reported na:i:0. It seems to come from #633.
This is a short fix, so that the
ChainDetailsare not lost in align mode. I also added a small update to the CONTRIBUTING.md, which still mentionned NAMs.BTW if we want to catch this in the future then we should use
--detailsin our phix test files, which would need to be updated on all details output change then.