fix: Return 4xx for admin validation failures - #31
Merged
Merged
Conversation
- internal/admin/handler/backends.go: return 400 when admin op reports !Success - internal/admin/handler/virtual_hosts.go: return 400 when admin op reports !Success - internal/admin/handler/config.go: return 400 when admin op reports !Success - helpers: clientErrorStatus for admin validation failures Fixes #22 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
ktrubilo9
requested changes
Aug 26, 2026
Owner
There was a problem hiding this comment.
Missing strings import in this file. clientErrorStatus uses strings.ToLower and strings.Contains, so the package currently fails to compile
CI failed on gofmt -l. Also add missing strings import used by clientErrorStatus so the package compiles after format cleanup. Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
ktrubilo9
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return 4xx for admin validation failures
Changes
Fixes #22