fix: scan each owner with its own credentials, not the previous owner's [patch]

[matt-edmondson]

Fixes #426

What was wrong

GitHubClient.Credentials is one mutable property on a client shared by every owner in the scan. ScanRemoteAccountsForRepos only assigned it when the owner had a PAT, or when a global login existed:

if (!string.IsNullOrEmpty(pat) || (!string.IsNullOrEmpty(Options.GitHubLogin) && !string.IsNullOrEmpty(Options.GitHubToken)))
{
    GitHubClient.Credentials = !string.IsNullOrEmpty(pat) ? new(owner, pat) : new(Options.GitHubLogin, Options.GitHubToken);
}

An owner matching neither branch does not get scanned anonymously — it gets scanned as whoever was set last.

The concrete case from the issue: a personal PAT is configured for owner A, and owner B is added with no credentials, just to browse publicly. B's scan runs as A. B's own private repositories are missed, and anything that genuinely needs B's auth answers with an ApiException that the caller swallows at lines 777-780 — so the repositories are simply missing, with no indication why.

The fix

ChooseCredentials makes the answer total, which is the property the old code lacked:

Owner PAT	Global login + token	Result
set	either	Credentials(owner, pat)
empty	both set	Credentials(login, token)
empty	either missing	Credentials.Anonymous

The caller now assigns its result for every owner, so nothing can carry over.

The third row also closes a smaller gap: a global login missing its token, or a token missing its login, used to be excluded by the guard and so silently left the previous credentials in place. It now falls through to anonymous rather than reaching Octokit, which rejects an empty half.

Tests

ProjectDirector.Test/ScanCredentialTests.cs, following the pattern CLAUDE.md sets out — the part with a rule in it is a plain method, drivable without a live ImGui context or a GitHub account.

AnOwnerWithNoCredentialsAnywhereIsScannedAnonymously is the regression itself: it asks for owner A with a PAT and then owner B with nothing, and asserts B comes back anonymous and specifically not as alpha.

Verified by substituting the original behaviour back in (returning the last-set credentials for an owner that matched neither branch) and re-running: AnOwnerWithNoCredentialsAnywhereIsScannedAnonymously, AGlobalLoginMissingItsTokenIsNotUsed and AGlobalTokenMissingItsLoginIsNotUsed all fail against it and pass against the fix.

Full suite on this branch: 45 total, 43 passed, 0 failed, 2 inconclusive (both need git-lfs, unrelated and present on main). dotnet build --configuration Release is clean.

Scope

The constructor's own one-time GitHubClient.Credentials assignment (lines 93-96) is left alone — a freshly constructed client is anonymous, so there is no stale identity for it to leak.

🤖 Generated with Claude Code

https://claude.ai/code/session_01EdV5iCFkUxFqkLZQAGLAVT

---

Generated by Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud