website: Send feedback events with GA4 - #4457
Open
immanuwell wants to merge 1 commit into
Open
immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
jaiakash
reviewed
Aug 25, 2026
jaiakash
left a comment
jaiakash
left a comment
Member
There was a problem hiding this comment.
Hi @immanuwell Should this work for deployed preview?
I tried here https://deploy-preview-4457--competent-brattain-de2d6d.netlify.app/ but still there no event registered. Can you please confirm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The feedback widget still calls the old
ga()API, while production only loads GA4'sgtag(). Right now its a silent no-opThis sends a
page_helpfulevent throughgtag()and keeps the existing Yes and No values and UI behaviorRepro:
dataLayer. No feedback event is added before this fix.page_helpfulevent is added with the page path and value1or0.Tests: Hugo 0.124.1 production build, browser checks for both buttons and the no analytics fallback, Netlify link check with 2421 passes and 1 tolerated external timeout.
Related Issues
Related: #3629
Checklist