Repository navigation
Conversation
kyleve
changed the title
There was a problem hiding this comment.
Posted by an AI agent on kve's behalf.
Settings after this change: native search stays visible in the split navigation drawer. Synthetic Duo inner portrait, light appearance, revision f9a01f74da1f. The fold-transition regression and all 20 full-content Settings images pass.
| var overrides: [GetterOverride] = [] | ||
| var methods: Set<Method> = [] | ||
| for bar in bars { | ||
| guard let method = class_getInstanceMethod(type(of: bar), selector), |
There was a problem hiding this comment.
Posted by an AI agent on kve's behalf.
Review focus: this test-only adapter temporarily intercepts the native accessibility getter. Results are scoped to captured bar instances, shared inherited methods are deduplicated, unrelated instances call the original getter, and every implementation is restored in defer, including thrown parses.
Window fitting lasts only while reading metadata. Image rendering and path parsing use the restored geometry. The SwiftUI split-navigation regression covers unrelated bars, unchanged paths, thrown operations, and subsequent native item updates.
f9a01f7 to
e9236bb
Compare
2fd6f69 to
eb54197
Compare
Keep all nine UIKit size-class combinations in the pane-policy regression while mapping through the two-case Broadway API. Unspecified inputs must still select a single pane. Validation: SwiftFormat and diff checks pass. Full unit integration runs at the rebased stack tip before publication; the root Broadway suites passed 141 tests.
Review 594 images and update 592 references while preserving raw PNG metadata. Two hydrated Elsewhere references already match. Validate all 2,975 iOS unit tests, 74 snapshot tests, 28 host macro tests, 31 architecture tests, and formatting/attribution checks. Retain native Duo 27.2 remeasurement and the pre-existing tall Year annotation limitation as explicit follow-ups.
eb54197 to
cc5e91f
Compare
0c7e8de to
bb29adb
Compare
Superseded
This follow-up is closed without merging. Its implementation and reviewed references now live in the layers that need them:
The active three-PR stack is #377 → #378 → #372. No implementation was discarded; the local follow-up tree is identical to #372 at
bb29adbcf00c0186a09ab82c3482b3a30aabb933.Validation and remaining work
Each active layer now has its own validation record. The final integration unit suite executed 2,975 tests with no unexpected failures. Adaptive lab, MainTabs, Settings, and the separately repeated Developer Overlay snapshots passed. Full per-layer CI is being rerun.
Native Duo 27.2 re-measurement and interactive release checks remain open in STU-316. Existing tall Year accessibility annotation limitations remain in STU-325. The search and capture work in STU-326 and STU-327 remains In Review with the owning PRs.