Repository navigation
feat: add php and maven to dependency proxy documentation - #317
Merged
Merged
Conversation
eliashaeussler
left a comment
eliashaeussler
left a comment
Contributor
There was a problem hiding this comment.
I can only speak for the PHP part: Thank you for this nice feature! I left a few remarks, but overall this reads very good and I'm excited to test it out :)
Collaborator
Author
|
@eliashaeussler Thanks a lot for the thorough review and the helpful pointers! I've tried to address everything you mentioned :) Let me know if anything is still missing or could be improved! |
Contributor
|
@juliankepka Very nice additions! The PHP/Packagist part LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These 2 pages are for the documentation of maven and php packages for the dependency proxy. The Pipeline will be red as long as the PRs are not merged into the backend.
Maven: l3montree-dev/devguard#3082
PHP: l3montree-dev/devguard#3123
I've tested them locally and both were fine.