Repository navigation
Conversation
liblsl 1.18.0.b4 ships the correct FALLBACK version in CMakeLists.txt, so release tarballs no longer need the version forced from the formula. The explicit `version` line stays: Homebrew still infers `4` from the pre-release tag URL.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
liblsl 1.18.0.b4 ships the correct
FALLBACKversion inCMakeLists.txt, so the formula no longer needs to force the version via-DLSL_VERSION_OVERRIDE.The explicit
versionline stays because Homebrew still infers4from the pre-release tag URL (v1.18.0.b4.tar.gz).Verified locally on arm64 macOS:
brew install --build-from-source,brew test,brew audit --strict --online,brew styleall pass;lslverreports 118.Closes #3