Repository navigation
lsl 1.18.0.b6: framework plus plain-dylib layout - #8
Merged
Merged
Conversation
On macOS, build lsl.framework again (#308): liblsl 1.18.0b6 also installs lib/liblsl.dylib, the headers in include/, lib/cmake/lsl and lsl.pc pointing into the framework, so -llsl, pkg-config and find_package(LSL) keep working. lib/liblsl.2.dylib links to it too, so programs built against the 1.18.0b3/b4 dylib layout (e.g. the labrecorder bottle) keep loading. The test also builds with -framework lsl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
lslto 1.18.0.b6 and, on macOS, installslsl.frameworkagain (sccn/liblsl#308) without giving up the plain-dylib layout.liblsl 1.18.0b6 installs a framework together with
lib/liblsl.dylib,include/{lsl,lsl_c.h,lsl_cpp.h},lib/cmake/lslandlsl.pc, all pointing into the framework (sccn/liblsl#320). So every way of using the formula works:-F$(brew --prefix)/Frameworks -framework lsl(#308)-I$(brew --prefix)/include -L$(brew --prefix)/lib -llsl,pkg-config lslfind_package(LSL)withCMAKE_PREFIX_PATH=$(brew --prefix)lib/liblsl.2.dylibalso links to the framework, so programs built against the 1.18.0b3/b4 dylib layout (which loadopt/lsl/lib/liblsl.2.dylib, e.g. the currentlabrecorderbottle) keep working without a rebuild. Linux is unchanged (plain shared library).Tested by installing this formula from source on macOS 26 arm64:
brew testpasses (C via-llsl,lslver, pkg-config, and a new-framework lslbuild),brew linkage lslis clean, Homebrew rewrites the framework's install name to/opt/homebrew/opt/lsl/Frameworks/lsl.framework/Versions/A/lsl, the installedlabrecorder(built against b4) still runs, and a CMakefind_package(LSL)consumer and a pkg-config consumer both build and run against/opt/homebrew. Bottles come from this PR's test-bot run.Fixes sccn/liblsl#308