Skip to content

spec-sync(v2): remove unwired extract options.grounding flag from spec - #166

Merged
tian-lan-landing merged 2 commits into
mainfrom
spec-sync/v2
Sep 15, 2026
Merged

tian-lan-landing merged 2 commits into
mainfrom
spec-sync/v2

Conversation

@yzld2002

@yzld2002 yzld2002 commented Sep 14, 2026 •

Copy link
Copy Markdown
Member

Automated V2 spec-sync PR (client.v2).

  • Commit 1 (mechanical): normalized V2 spec snapshot + regenerated reference models.
  • Commit 2 (AI, only if the spec diff needs SDK changes): client.v2 resources/methods/tests/docs wired from the diff, added after this PR opened. Workflow-only drift is excluded and an AI no-op is skipped, so some drifts produce a mechanical-only PR with no second commit.

Gates (surface-lock, V2 contract tests, lint/test/typecheck) must pass. When present, the AI commit is a draft a human finishes (the V2 ergonomic layer — unified Job, dual-host, schema coercion — is not in the spec). Human review required before merge.

What changed

AI-generated from the PR diff — verify against the actual changes.

This PR removes the never-wired options.grounding extract flag from the spec, restoring strict as the only supported extraction option and closing off the previous extra_body workaround.

Changes:

  • Removed options.grounding from the /v2/extract and /v2/extract/jobs request schemas (sync and async, JSON and form-data variants).
  • extract options are once again limited to strict; the options object's additionalProperties: false now rejects the previously-suggested extra_body={"options": {"grounding": False}} workaround.
  • Updated docs/v2-testing.md to remove guidance on the unwired grounding option and note the escape hatch no longer works.
  • No response fields changed; V2ExtractResult/extraction_metadata behavior is unaffected.

Copilot AI balanced review requested due to automatic review settings September 14, 2026 23:02
@yzld2002
yzld2002 deployed to spec-sync-contract September 14, 2026 23:02 — with GitHub Actions Active

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The pull request explicitly requires human review before merge.

Pull request overview

This mechanical V2 spec-sync removes the preview grounding extraction option and regenerates the related models.

Changes:

  • Updated the V2 API snapshot.
  • Removed grounding from extraction options.
  • Regenerated extraction request models and descriptions.
File summaries
File Description
specs/v2-aide.json Updated V2 API snapshot.
specs/_generated/v2_models.py Regenerated extraction models.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite (auto)

Note

Copilot is running an experiment and ran this review at Lite.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI review requested due to automatic review settings September 14, 2026 23:04
@yzld2002 yzld2002 changed the title spec-sync: track V2 spec drift spec-sync(v2): remove unwired extract options.grounding flag from spec Sep 14, 2026
@yzld2002
yzld2002 deployed to spec-sync-contract September 14, 2026 23:04 — with GitHub Actions Active

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Update the remaining api.md guidance that documents the now-rejected workaround.

Get a fresh assessment by requesting another Copilot review.

Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Lite (auto)

Note

Copilot is running an experiment and ran this review at Lite.

Comment thread docs/v2-testing.md
@tian-lan-landing
tian-lan-landing merged commit c4e0c1d into main Sep 15, 2026
6 checks passed

This branch was successfully deployed

1 active deployment
spec-sync-contract — 85893c07 Deployed Sep 14, 2026 by yzld2002 via contract-tests #180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants