Repository navigation
spec-sync(v2): remove unwired extract options.grounding flag from spec - #166
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The pull request explicitly requires human review before merge.
Pull request overview
This mechanical V2 spec-sync removes the preview grounding extraction option and regenerates the related models.
Changes:
- Updated the V2 API snapshot.
- Removed
groundingfrom extraction options. - Regenerated extraction request models and descriptions.
File summaries
| File | Description |
|---|---|
specs/v2-aide.json |
Updated V2 API snapshot. |
specs/_generated/v2_models.py |
Regenerated extraction models. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Update the remaining api.md guidance that documents the now-rejected workaround.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated V2 spec-sync PR (
client.v2).Gates (surface-lock, V2 contract tests, lint/test/typecheck) must pass. When present, the AI commit is a draft a human finishes (the V2 ergonomic layer — unified Job, dual-host, schema coercion — is not in the spec). Human review required before merge.
What changed
AI-generated from the PR diff — verify against the actual changes.
This PR removes the never-wired
options.groundingextract flag from the spec, restoringstrictas the only supported extraction option and closing off the previousextra_bodyworkaround.Changes:
options.groundingfrom the/v2/extractand/v2/extract/jobsrequest schemas (sync and async, JSON and form-data variants).extractoptions are once again limited tostrict; theoptionsobject'sadditionalProperties: falsenow rejects the previously-suggestedextra_body={"options": {"grounding": False}}workaround.docs/v2-testing.mdto remove guidance on the unwiredgroundingoption and note the escape hatch no longer works.V2ExtractResult/extraction_metadatabehavior is unaffected.