test(client): add unit test suite for observation metadata nested key serialization - #1875
Open
gcoinstash-cmd wants to merge 1 commit into
Open
Conversation
|
|
Comment on lines
+1
to
+3
| import pytest | ||
|
|
||
| def sanitize_metadata(meta: dict) -> dict: |
Contributor
There was a problem hiding this comment.
The pytest import is unused, and the module-level functions on lines 3, 12, and 16 lack the two blank lines required by Ruff. Because CI runs ruff check ., this test file prevents the lint workflow from passing.
Prompt To Fix With AI
This is a comment left during a code review.
Path: tests/test_observation_metadata_invariants.py
Line: 1-3
Comment:
**Test File Fails Lint**
The `pytest` import is unused, and the module-level functions on lines 3, 12, and 16 lack the two blank lines required by Ruff. Because CI runs `ruff check .`, this test file prevents the lint workflow from passing.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Author
|
I have read the CLA Document and I hereby sign the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds focused unit tests verifying observation metadata nested dictionary serialization:
The PR is not ready to merge because its new test module fails the required lint workflow, and the tests do not validate the production behavior they claim to cover.
Summary
Reviews (1) · Last reviewed commit: "test(client): add unit test suite for ob..."