Repository navigation
feat: name CI-skipped tests in review; group fix commits by concern - #131
Merged
Merged
Conversation
- github-pr-reviewer names the tests a diff adds that CI does not run, read from the workflow's commands and the tests' markers or paths - pr-fix commits per thread or per group of threads sharing a concern, and offers one optional summary comment, posted under the replies' yes - pr-fix and github-pr-fix-planner state the sibling-or-upstream move rule inline instead of citing D-006, a decision the plugin does not ship - comment-style rules out "just", "simply" and "obviously" Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maintainer's own review skills had been doing the work
pr-reviewandpr-fixare meant to do, so the plugin's versions saw little real use. Comparing the two turned up a few things the personal copies did that the plugin's did not. It also turned up a defect:pr-fixandgithub-pr-fix-plannerstated their move rule "as D-006 says". D-006 is a decision in one project's standard that the plugin does not ship, so in every other repository the rule pointed at nothing. Once this merges, the plugin's versions cover what the personal ones did, and the personal copies can be retired.github-pr-reviewernames the tests a diff adds that CI does not run. It reads them from the workflow's commands and the tests' markers or paths, and runs nothing.pr-fixcommits per thread or per group of threads sharing a concern. It can also offer one summary comment, drafted with the replies and posted only under their yes.comment-style.mdrules out "just", "simply" and "obviously".No test reads this wording.
Origin: the maintainer's comparison of personal review skills with the plugin's (no issue filed)
Sandbox: none for these items; they need a pull request's diff and threads, which the offline GitHub stub does not serve. Three other candidates (a test-runner live-suite rule, a wider test-runner description, a changelog check in the documentation focus) were dropped after a Haiku compare showed main already behaves that way, 8/8 runs per side.
Canary: not yet run
🤖 Generated with Claude Code. AI assistance level: 4/5 (read by a person, not edited).