fix(web): escape formatting at composer boundaries - #295
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
17c3245 to
f7154d2
Compare
|
@codex review |
Replace the paste-only typing mark reset with a standalone rich composer extension. Placing the caret follows the text on its right or types plain at a line end; paste, cut, and history restoration use the same rule. Normal edits and explicit formatting continue using inclusive marks. Carry-Group: upstream-bugfixes Carry-Upstream: pingdotgg#13518 (head cc1d991) Carry-Supersedes: #251 (paste-only typing mark reset) Carry-Observation: Clipboard cut follows the same boundary rule as paste; real drops select their inserted content and use the later caret-placement rule. Caret movement clears ProseMirror stored marks and reintroduces implicit formatting. Keep inclusive schemas for sustained formatting shortcuts; isolate the boundary policy in an extension to reduce shared composer carry conflicts.
f7154d2 to
ada9e07
Compare
|
Local review completed for
The real-client recording uses editor caret-placement commands because the preview tool's native Meta-arrow dispatch did not reliably move the caret. GitHub CI and a fresh Codex review remain required on this final head before the LastCode merge. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Moving the caret away from formatted text and back to its end makes subsequent typing inherit that formatting. For example,
**b**followed by line-start/line-end navigation andplainbecomes**b plain**. The earlier fix in #251 reset typing marks only after paste; moving the caret discarded that reset.Replace the paste-specific helper with a small rich composer extension. Caret placement, paste, cut, and history restoration follow the text to the right, or type plain at a line end. Normal typing and explicit formatting shortcuts retain inclusive marks. The upstream diff touches the shared composer only to import and register the extension; the LastCode change belongs to
upstream-bugfixesand records the superseded paste-only fix.Validation: 106 focused tests pass in both the LastCode branch and the clean upstream branch, plus targeted lint. An isolated real-client pass verifies cursor placement, focused paste, paste-to-focus, and sustained Cmd+I typing. This applies to the shared web/desktop rich composer; the native mobile editor and provider/server paths are unchanged.
Upstream contribution: pingdotgg#13518.
Before:
**b plain**after placing the caret at line start and line end.After:
**b** plainusing the same caret placements.Short before/after recording. The baseline disables only the new plugin; the recording uses editor selection commands for caret placement. Native Meta-arrow dispatch in the preview tool did not reliably move the caret.
Implemented by GPT-6.1-Sol (xhigh) through Codex in T3 Code, with design input from GPT-6-Astra High and Claude Opus 5.5 High.