Repository navigation
test(lastcode): keep CLI errors visible during package validation - #296
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
SQLite warnings can occupy stderr while the decode error is on stdout. Check both streams so the reconciliation regression stays meaningful under the package builder's Node runtime. Carry-Group: build-ci Carry-Fix: Local package reconciliation diagnostic regression Carry-Observation: A Node 24 SQLite warning must not hide a decode error written to stdout from the regression assertion.
566fe29 to
1d25cdb
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Local package validation failed when Node's SQLite warning on stderr hid the expected CLI decode error on stdout from the reconciliation regression test.
Combine both output streams when checking the failure diagnostic. The test still verifies failure status and preserves the managed Action state after invalid input.
Validation: reproduced the failure under Node 24.13.1; all 24 focused CLI and Action-wrapper tests pass with the correction, along with scoped lint and diff checks. Full validation runs in GitHub CI.
Implemented with GPT-6.1-Sol in the Codex harness.