Repository navigation
fix(browser): use upstream queue deadlines for background QA - #740
Conversation
Restore upstream's numeric dispatch deadline API and remove the signal/deadline overload. Keep active cancellation at the existing native-operation and page boundaries, plus native rendering and background host subscriptions that upstream's queued-expiry fix does not cover. Carry-Group: upstream-bugfixes Carry-Fix: #720; reconciles #325 Carry-Upstream: https://redirect.github.com/pingdotgg/t3code/pull/16941 merge=8f947a313b29c30c1deb9960ea0450482cb6e19f original-head=f88dc5fb4c6b91bd5715d3aacf5f931bb1fba6b9 Carry-Observation: Deadline-only SessionControl API matches upstream. Native rendering, root subscriptions, broker retirement and page cancellation remain necessary for broader background QA behavior.
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
#325 vs upstream pingdotgg#16941: reconciled in PR #740; open, blocked by existing CI failures. Upstream https://redirect.github.com/pingdotgg/t3code/pull/16941, merge PR #740 restores upstream's numeric queue-deadline API and removes the duplicate signal-aware overload. The broader native-rendering, background-subscription, broker-isolation and page/recording-cancellation behavior stays because upstream's dispatch check does not cover it. Cancellation remains at the existing native-operation seam. Four server files changed: 45 lines added, 63 removed. Validation: changed-file checks passed, including 354 tests and affected typechecks; exact-head Quick CI passed. One local Terra xhigh review approved, and one exact-head GitHub Codex review found no issues. Zero unresolved review threads. Merge blocker: CI failed twice on head Next: diagnose the existing server-test worker memory exhaustion and dev-runner process-fixture startup failures, then obtain green CI before guarded merge. This is incomplete until #740 merges. #720 remains open because it also tracks other audit decisions. |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Block only the dialog expression rather than every Runtime.evaluate command. A late title watch must remain pending until its title changes instead of repeatedly treating the dialog answer as a title-change notification. Carry-Group: incubator Carry-Fix: #740 Carry-Observation: Repairs the existing browser dialog fixture after CI exhausted its worker heap; production behavior is unchanged. The dialog fixture is introduced by the incubator group and the repair must replay after that fixture exists.
Stub Cargo in the process-tree fixture so a cold checkout cannot compile the resource monitor before reaching the shutdown assertion. Include captured output in startup failures so the cause is visible. Carry-Group: incubator Carry-Fix: #740 Carry-Observation: Shutdown fixture repair; no production behavior changed. The process-tree fixture is introduced by the incubator group, so its feature-specific test repair must replay with that group.
9f6a306 to
6678ee2
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Background QA carried two queue-deadline designs side by side: upstream's numeric deadline and LastCode's signal-aware overload of
SessionControl.agent. This goes back to upstream's API and keeps cancellation at the existing native-operation boundary.🔎 Why
8f947a313b29c30c1deb9960ea0450482cb6e19f) is an ancestor of bothorigin/mainand the LastCode base6cd814fceafb68cfd26d475e2a1f038b88f2c534.f18ac3cc1fee9fe4aa213415faa0660ba4df993b(LastCode fix(browser): keep background QA usable and restore saved handoffs #325, imported at pinned headf88dc5fb4c6b91bd5715d3aacf5f931bb1fba6b9) added signal-aware queue handling. The combined queue retained anumber | AbortSignaloverload alongside upstream's deadline API.🛠 What changed
SessionControl.agent(agentId, run, deadlineMs?): restored to upstream's signature. The number-or-AbortSignaloverload is gone.ServerBrowsercall sites: the 2 signal arguments are removed.withNativeSurfaceabort gate and page/broker cancellation stay.📌 Still carried beyond upstream
Upstream's deadline only stops expired queued work from starting. It doesn't cover hidden painting or work that is already running, so these stay:
1722a7ae9060883d71d3ba06872c54076dec6bf1. This is carried separately and is not part of this overlap.✅ Proof
6678ee249474e65cab44dff5a8bed1eeb3e1e16fagainst6cd814fceafb68cfd26d475e2a1f038b88f2c534.running -> finished -> expired-skipped -> recording-cleanup -> fresh-input.Local review: 1 rounds with gpt-6.1-terra (xhigh), approved.
CI fixture repairs
CI also exposed two failures already present on the base. The browser dialog mock intercepted background title watches as well as the dialog expression; it now blocks only that expression. The dev-runner shutdown fixture invoked Cargo on cold checkouts before reaching its fake process tree; it now stubs Cargo and includes captured output in startup failures. Neither repair changes production behavior.
🔗 Tracking
Partial audit work for #720. That issue also covers other ongoing audit decisions, so this PR does not close it.
Implemented with GPT-6.1 Sol through the Codex harness in T3 Code.