Repository navigation
chore: a committed exact-HEAD gate, one Node pin (24.22.1), CI failure reader and earlier outside review (Cycle 0058 retro) - #146
Merged
Conversation
- `.node-version` moves to 24.22.1 (owner decision), mirrored in `extension/.node-version`: vite-plus's `node` shim reads the nearest package's `engines.node` under extension/ and ran 24.22.1 there while the root pinned 24.21.0. - `package.yml` reads `node-version-file: .node-version` like the other workflows instead of its own literal. - The measured health baseline was taken again from 944c134 with Node 24.22.1 and the same c8 12.0.0, v8-to-istanbul 9.3.0, fallow 3.34.1 and settings: byte-identical (e74f7142…, 278 entries). The reference records the new Node and the new `.node-version` hash (d9f31874…).
…urces Committed with --no-verify: the global gitignore ignores .gstack, so the lint-staged hook cannot re-stage this file (prettier --check passes).
- `pnpm --dir extension gate` runs the fifteen delivery checks in order, one log each under artifacts/gate/<HEAD>. It refuses a Node or pnpm off the pins and a checkout with changes, sets an English locale, puts the running Node first on the path, and passes only when every check exited 0 on an unmoved HEAD. It replaces the per-cycle shell copy that reported success while nine checks failed on a missing corepack. - `node extension/scripts/ci-failures.mjs <PR>` (or `--run <id>`) prints each failed job's failing tests with their first error line, also while the run goes on.
…ing review rule - AGENTS.md: the gate and CI-failure commands; the pinned Node's own bin first in PATH; Codex structured review in /ship Step 9 pass 1 and on plans that change signalling, identity or stop paths, with fix-range passes dispatching only the reviewers their area needs (owner decision); the CodeRabbit CLI 0.9.1 schema failure of `config validate`; a pointer to the native-trial observation doc. - docs/agents/native-trial-observation.md: check state with text (window list, accessibility tree and actions, space_bash) and Read cropped, reduced captures; full-size stills stay the evidence files. - .coderabbit.yaml: a review rule for process-signalling code (an identity verdict within the signal's bound; a signal-0 probe is no identity; no signal after its owning operation returned).
…ter 300 s of silence (local CodeRabbit CLI) A signal to the gate now ends the running check's whole tree before the gate exits (130/143/129), and a check that prints nothing for the silence bound (--silence-seconds, default 300) is ended and fails as exit 124, so the gate can neither hang nor leave a check rebuilding extension/dist under the next run.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The retro of Cycle 0058's delivery (Refs #143) found that the merge gate was a shell script copied from cycle to cycle. When the machine's version manager disappeared mid-delivery, nine of its checks failed with exit 127, and the run still reported success. It also found that the Node under
extension/differed from the pin, and that the review that caught the cycle's one P1 came only after the three-cycle review cap. This PR applies the owner-approved fixes, all except slimming AGENTS.md, which stays as intended:pnpm --dir extension gateruns the fifteen delivery checks in order, with one log each underartifacts/gate/<HEAD>..node-version, mirrored inextension/.node-versionand read bypackage.ymlthroughnode-version-file. vite-plus's shim readengines.nodeunderextension/and ran 24.22.1 there while the root pinned 24.21.0; a test keeps the two files equal.node extension/scripts/ci-failures.mjs <PR>(or--run <id>) prints each failed job's failing tests with their first error line, also while the run is still going./shipStep 9 pass 1 also runs the Codex structured review, and a plan that changes process signalling, identity or a stop path gets a Codex review before implementation. Fix-range passes under 300 lines dispatch only the reviewers their area needs..coderabbit.yamlfor the node-server stop and sweep files:docs/agents/native-trial-observation.md, pointed to from AGENTS.md Native QA): check state with text (window list, accessibility tree and actions,space_bash) and Read cropped, reduced captures. Screenshots were 85% of all tool output in Cycles 0056 to 0058.config validateexits 1 on every file withunknown keyword: "x-undocumented", a defect in the CLI's own schema. AGENTS.md now says to record that line; reviews with-cstill apply the file.Blast radius
No product source changes: the VSIX's code and its behavior are untouched. What moves is the toolchain pin, which applies to CI, the gate and local runs (Node 24.22.1, one patch above VS Code's bundled 24.21.0; Cursor bundles 24.19.0). The measured health gate depends on the pin. Its baseline was taken again from
944c1342with Node 24.22.1 and the same c8 12.0.0, v8-to-istanbul 9.3.0, fallow 3.34.1 and settings, and came out byte-identical (e74f7142…, 278 entries; script ran). Only the reference's Node version and its.node-versionhash (d9f31874…) change.Health baseline retake (AGENTS.md Fallow)
944c1342with Node 24.22.1 (vite-plus runtime), its own complete suite under c8 (--all, Istanbul JSON): 4,261 tests, 4,258 pass, 0 fail, 3 skipped on macOS (two Linux-only pid-namespace tests skip here); 401 coverage files, all 401 scored by Fallow.fallow health --save-baselineat 20/15/30 with the current.c8rc.jsonand.fallowrc.json: byte-identical to the committed baseline.Test plan
node --test extension/scripts/tests/gate.test.mjs extension/scripts/tests/ciFailures.test.mjs: 12/12; withpregateTestsandworkflowPinsthe affected script tests passGate refused: Node 24.21.0 runs here, but .node-version pins 24.22.1.(exit 2)ci-failures.mjs --run 40603051333lists the four Node 26 failures of PR chore(ci): bump Node.js to 26.12.1 (needs the Node 26 migration before merge) #145's earlier runpnpm --dir extension gateonf8c0c3ab(Node 24.22.1):GATE: pass, every check exit 0. That covers the suite (7,921 tests, 7,911 pass, 0 fail, 10 skipped), the package tests (1,093 / 1,083 / 0 / 10) and health (86 A, on the retaken reference)fb85dbd1, with a test that ends a silent real process (exit 124). The rerun found 0🤖 Generated with Claude Code