Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the browser Studio alongside the CLI, with account-owned projects, persistent jobs, version restore/publishing, marketplace ratings, and a bounded game production pipeline. Includes image imports/generation/batches, study courses, optional Privy login, referrals and disabled-by-default PayPal credit purchases.
Review fixes upgrade Next.js to 16.4.3 and Studio Sharp to 0.35.5, correct lint configuration and React hook dependencies, preserve draft fields during polling, and add Studio type/unit checks to the existing workspace CI command. The diff includes two pre-existing local commits plus previously uncommitted Studio work and research notes.
Evidence
test:ci, and lint rejected its Node tests and public Next.js entry points.After: production build, repository build/typecheck/lint, and lockfile validation passed. Studio checks now run in workspace CI.
npm run test:ci: 6,536 passed, 10 skipped across CLI, core, SDK, Studio and script tests. Initial run lacked the legacy CLI Sharp native binary; rebuilt it and the rerun passed.output/,tmp/,sites/, andtools/directories.npm run preflightwas not invoked verbatim because it deletes installed dependencies and formats the whole dirty workspace; build, lint, typecheck and test checks were run separately. No production deployment or new metered model generation was performed in this review.Merge Danger
Door: two-way for code before payment activation; database additions persist. After sales start, do not roll back to code that ignores paid-credit accounting.
Blast Radius: Studio
New SQL tables/columns, worker behavior and web dependencies. Core/CLI source is unchanged. Private generated output, temporary scripts, the unrelated traffic-monitor utility and nested site repository remain local and uncommitted. Research notes include local evidence links under
output/; those artifacts are not part of this PR. Model-written acceptance cases and visual reviews are limited evidence, not proof of complete gameplay or audio quality.No linked implementation issue: this PR delivers the user's explicit request to review existing work; creating a separate tracking issue was not authorized by automatic approval review. Leave open and unmerged.
Final PR review
Reviewed head:
9ac67c0040017e7a741ddb8a49d216c85ab7d17c; base remainsc9bea37786af524bf3bbe802f2b67d23816fa5c0. All 229 GitHub file entries and blob hashes match the reviewed local diff. GitHub refuses the combined diff because it exceeds 20,000 lines; the per-file API was used to verify it. No merge conflicts or review comments were present.Remote CI is blocked: Qwen Code CI run reports
action_required, with zero jobs started. An upstream maintainer must resolve the workflow action/approval requirement. Local checks are green, but missing remote checks are not a CI pass and this PR is not yet declared merge-ready.