Skip to content

branch gate: a moved comment and a reworded doc line count as added comments #29

Open

Description

@lenamonj

housebroken branch flags every comment line in the added side of the diff. Two cases on uber/h3#1236 (head 9ff062a5) are not additions: (1) upstream's own five-line comment on cmp_uint64 moves from cellsToMultiPoly.h to h3Index.h together with the function, and (2) one line of an existing @return docstring is reworded because the function returns a new error code. The skill text already allows rewording a comment that is there; the gate does not. Proposed: pair each added comment line with an identical or edited removed line elsewhere in the diff (a move or a rewording) before counting it, and print the pairing so the reader can check it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions