Conversation
Pins LF in the working tree regardless of core.autocrlf, so Windows checkouts (Git for Windows defaults to autocrlf=true) match the repo. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013AdTeADfo4e7vzGstUSnSM
cmd.exe passes single quotes through literally, so eslint received
'**/*.{ts,js,vue}' including the quotes and found no files on Windows.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013AdTeADfo4e7vzGstUSnSM
Runs on windows-latest with core.autocrlf=true, checks that no file except *.cmd/*.bat is checked out with CRLF, then builds the playground, builds the module and lints. Separate workflow with continue-on-error, so next.yml and release.yml never wait on it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013AdTeADfo4e7vzGstUSnSM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of native Windows support (PowerShell / Git Bash, no WSL). Only changes that don't depend on a test on a real Windows machine.
Changes
.gitattributes: LF in the working tree regardless ofcore.autocrlf. Git for Windows defaults toautocrlf=true; a clone with that setting has 149 CRLF files onmainand 1 on this branch. The remaining one isplayground/server/true.cmd, which*.cmd text eol=crlfchecks out with CRLF on purpose.git add --renormalize .produces no content change..editorconfigalready setsend_of_line = lf.lint/lint:fix: the glob is now double-quoted. cmd.exe passes single quotes through literally, so eslint received'**/*.{ts,js,vue}'including the quotes and reported "No files matching the pattern"..github/workflows/windows.yml: separate workflow onwindows-latestwithcontinue-on-error: true. Nothing innext.ymlorrelease.ymlwaits on it, so a red run never holds up a release. Steps:core.autocrlf=true, checkout, fail if any file other than*.cmd/*.batis checked out with CRLF,npm ci, build playground (the module tsconfig extendsplayground/nuxt-app/.nuxt/tsconfig.json),npm run build,npm run lint. Nodelts/*, same as the existing Linux workflows.Pre-existing, not caused by this PR
npm run lintalready fails onmainon every platform: ESLint 9.34 rejects the config from@lenne.tech/eslint-config-vue2.1.3 (vue/object-property-newline: unexpected propertyallowMultiplePropertiesPerLine). No workflow ran lint so far. The Windows lint step stays red until that dependency is fixed.Published package
No blocker found for Windows consumers:
dist/has no shell calls or POSIX-only commands, and paths go through Nuxt's resolver.scripts/bundle-interop.mjsis build-time only and not published.🤖 Generated with Claude Code
https://claude.ai/code/session_013AdTeADfo4e7vzGstUSnSM