Skip to content

Add operator to fetch cookies by their key #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
COM8 merged 2 commits into from
Jul 26, 2026
+15 −2
Merged

Add operator to fetch cookies by their key #1312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba6b948
Add operator to fetch cookies by their key
Callen44 Jul 1, 2026
04bb02a
use find_if instead of manually looping.
Callen44 Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion cpr/cookies.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#include "cpr/cookies.h"
#include "cpr/curlholder.h"

#include <algorithm>
#include <chrono>
#include <ctime>
#include <iomanip>
Expand Down Expand Up @@ -73,6 +75,16 @@ cpr::Cookie& Cookies::operator[](size_t pos) {
return cookies_[pos];
}

cpr::Cookie& Cookies::operator[](const std::string& key) {
const auto it = std::find_if(cookies_.begin(), cookies_.end(), [key](const cpr::Cookie& c) { return c.GetName() == key; });

if (it == cookies_.end()) {
throw std::out_of_range{"Cookie: " + key + " does not exist"};
}

return *it;
}

Cookies::iterator Cookies::begin() {
return cookies_.begin();
}
Expand Down Expand Up @@ -113,4 +125,4 @@ void Cookies::pop_back() {
cookies_.pop_back();
}

} // namespace cpr
} // namespace cpr
3 changes: 2 additions & 1 deletion include/cpr/cookies.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ class Cookies {
Cookies(const cpr::Cookie& cookie, bool p_encode = true) : encode{p_encode}, cookies_{cookie} {}

cpr::Cookie& operator[](size_t pos);
cpr::Cookie& operator[](const std::string& key);
[[nodiscard]] std::string GetEncoded(const CurlHolder& holder) const;

using iterator = std::vector<cpr::Cookie>::iterator;
Expand All @@ -86,4 +87,4 @@ class Cookies {
};
} // namespace cpr

#endif
#endif
Loading