Split ~future_base() into inline fast path + out-of-line slow path - #108
Merged
Conversation
…ow path The common case (m_tag == state_tag::value) needs no cleanup, so keep only that check inline in the destructor. The exception_ptr/cancel cleanup moves into destroy_slow(), out-of-line and shared across every future<T> instantiation, mirroring the existing throw_failure() pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
m_tag == state_tag::value) needs no cleanup, so~future_base()now only does a single inline branch check.destroy_slow(), marked[[unlikely]]at the call site and out-of-line, shared across everyfuture<T>instantiation — same pattern as the existingthrow_failure().Test plan
conan build . -pr:a hal/tc/gcc— existing unit tests pass unmodified