bobyqa: replace trueloc indexing with allocation-free where/masked sum - #315
Open
pawlenartowicz wants to merge 1 commit into
Open
bobyqa: replace trueloc indexing with allocation-free where/masked sum#315pawlenartowicz wants to merge 1 commit into
pawlenartowicz wants to merge 1 commit into
Conversation
Every y(trueloc(mask)) in fortran/bobyqa/ becomes where(mask) y = ... or sum(..., mask=mask). Same floating-point operations in the same order; trajectories and all internal states are bit-identical to the previous commit. Removes 3-4 heap allocations per call site from the trsbox and geostep hot loops; 1.7x-2.1x faster per solve with gfortran 15 -O3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every y(trueloc(mask)) in fortran/bobyqa/ becomes where(mask) y = ... or sum(..., mask=mask). Same floating-point operations in the same order; trajectories and all internal states are bit-identical to the previous commit. Removes 3-4 heap allocations per call site from the trsbox and geostep hot loops; 1.7x-2.1x faster per solve with gfortran 15 -O3.