Skip to content

chore(grid-visualizer): sync with /quotes deprecation - #863

Open
claude[bot] wants to merge 1 commit into
mainfrom
docs/sync-20260825
Open

chore(grid-visualizer): sync with /quotes deprecation#863
claude[bot] wants to merge 1 commit into
mainfrom
docs/sync-20260825

Conversation

@claude

@claude claude Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update Grid Visualizer code generator to use POST /quotes for all transfers
  • Remove deprecated /transfer-in and /transfer-out endpoint code paths
  • Same-currency, non-JIT transfers now use immediatelyExecute: true to combine quote creation and execution

This syncs the Grid Visualizer with the OpenAPI schema changes from #856 which deprecated /transfer-in and /transfer-out in favor of the unified /quotes endpoint.

Areas updated

Grid Visualizer (components/grid-visualizer/src/lib/code-generator.ts)

  • All transfer flows now generate /quotes API calls instead of the deprecated endpoints
  • Same-currency, pre-funded transfers use immediatelyExecute: true for a single-request flow
  • Step titles and notes updated to reflect the new behavior

Documentation - Already up to date

  • Changelog documents the deprecation
  • Quote system guide includes deprecation notice
  • No guides recommend the deprecated endpoints

Kotlin Sample - Already up to date

  • Uses /quotes endpoint, not deprecated endpoints

Test plan

  • Verify Grid Visualizer generates correct API calls for same-currency internal→external transfer
  • Verify Grid Visualizer generates correct API calls for cross-currency transfers
  • Verify JIT funding flows still generate payment instruction steps

🤖 Generated with Claude Code

…ted endpoints

Update the code generator to use POST /quotes for all transfers instead
of the deprecated /transfer-in and /transfer-out endpoints. Same-currency,
non-JIT transfers now use immediatelyExecute: true to combine quote
creation and execution in a single request.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@claude
claude Bot requested review from pengying and shreyav August 25, 2026 08:19
@vercel

vercel Bot commented Aug 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview Aug 25, 2026 8:20am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
grid-wallet-demo Ignored Ignored Aug 25, 2026 8:20am

Request Review

@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR migrates Grid Visualizer transfer examples from the deprecated transfer endpoints to the unified quote API.

  • Generates POST /quotes for every transfer flow.
  • Uses immediatelyExecute for same-currency, non-JIT transfers and suppresses the separate execution step.
  • Preserves JIT payment-instruction steps, but drops the outbound remittance-information example during migration.

Confidence Score: 4/5

The migration should not merge until the generated outbound quote preserves the recipient remittance reference carried by the former transfer-out request.

The unified quote request supports remittanceInformation, but the generator drops it for the migrated same-currency outbound flow, changing the payment details shown to integrators.

Files Needing Attention: components/grid-visualizer/src/lib/code-generator.ts

Important Files Changed

Filename Overview
components/grid-visualizer/src/lib/code-generator.ts Migrates all generated transfer flows to quotes, but the replacement outbound quote body omits the previously demonstrated remittance information.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Selected transfer] --> B{Same currency and non-JIT?}
  B -->|Yes| C[POST /quotes with immediatelyExecute]
  B -->|No| D[POST /quotes]
  D --> E{JIT funding?}
  E -->|Yes| F[Follow paymentInstructions]
  E -->|No| G[POST /quotes/id/execute]
Loading
Prompt To Fix All With AI
### Issue 1
components/grid-visualizer/src/lib/code-generator.ts:223-229
**Outbound remittance reference is dropped**

When generating a same-currency, pre-funded internal-to-external transfer, the replacement quote body omits `remittanceInformation`, causing the invoice/reference previously sent through ACH Addenda, RTP/FedNow remittance, or wire OBI to be lost.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "chore(grid-visualizer): use /quotes for ..." | Re-trigger Greptile

Comment on lines 223 to 229
@@ -291,21 +228,32 @@ export function generateSteps(
purposeOfPayment: 'GIFT',
};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Outbound remittance reference is dropped

When generating a same-currency, pre-funded internal-to-external transfer, the replacement quote body omits remittanceInformation, causing the invoice/reference previously sent through ACH Addenda, RTP/FedNow remittance, or wire OBI to be lost.

Knowledge Base Used: Payments, quotes, and transfers API

Prompt To Fix With AI
This is a comment left during a code review.
Path: components/grid-visualizer/src/lib/code-generator.ts
Line: 223-229

Comment:
**Outbound remittance reference is dropped**

When generating a same-currency, pre-funded internal-to-external transfer, the replacement quote body omits `remittanceInformation`, causing the invoice/reference previously sent through ACH Addenda, RTP/FedNow remittance, or wire OBI to be lost.

**Knowledge Base Used:** [Payments, quotes, and transfers API](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/payments-and-quotes-api.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants