chore(grid-visualizer): sync with /quotes deprecation - #863
Conversation
…ted endpoints Update the code generator to use POST /quotes for all transfers instead of the deprecated /transfer-in and /transfer-out endpoints. Same-currency, non-JIT transfers now use immediatelyExecute: true to combine quote creation and execution in a single request. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile SummaryThe PR migrates Grid Visualizer transfer examples from the deprecated transfer endpoints to the unified quote API.
Confidence Score: 4/5The migration should not merge until the generated outbound quote preserves the recipient remittance reference carried by the former transfer-out request. The unified quote request supports remittanceInformation, but the generator drops it for the migrated same-currency outbound flow, changing the payment details shown to integrators. Files Needing Attention: components/grid-visualizer/src/lib/code-generator.ts
|
| Filename | Overview |
|---|---|
| components/grid-visualizer/src/lib/code-generator.ts | Migrates all generated transfer flows to quotes, but the replacement outbound quote body omits the previously demonstrated remittance information. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Selected transfer] --> B{Same currency and non-JIT?}
B -->|Yes| C[POST /quotes with immediatelyExecute]
B -->|No| D[POST /quotes]
D --> E{JIT funding?}
E -->|Yes| F[Follow paymentInstructions]
E -->|No| G[POST /quotes/id/execute]
Prompt To Fix All With AI
### Issue 1
components/grid-visualizer/src/lib/code-generator.ts:223-229
**Outbound remittance reference is dropped**
When generating a same-currency, pre-funded internal-to-external transfer, the replacement quote body omits `remittanceInformation`, causing the invoice/reference previously sent through ACH Addenda, RTP/FedNow remittance, or wire OBI to be lost.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "chore(grid-visualizer): use /quotes for ..." | Re-trigger Greptile
| @@ -291,21 +228,32 @@ export function generateSteps( | |||
| purposeOfPayment: 'GIFT', | |||
| }; | |||
There was a problem hiding this comment.
Outbound remittance reference is dropped
When generating a same-currency, pre-funded internal-to-external transfer, the replacement quote body omits remittanceInformation, causing the invoice/reference previously sent through ACH Addenda, RTP/FedNow remittance, or wire OBI to be lost.
Knowledge Base Used: Payments, quotes, and transfers API
Prompt To Fix With AI
This is a comment left during a code review.
Path: components/grid-visualizer/src/lib/code-generator.ts
Line: 223-229
Comment:
**Outbound remittance reference is dropped**
When generating a same-currency, pre-funded internal-to-external transfer, the replacement quote body omits `remittanceInformation`, causing the invoice/reference previously sent through ACH Addenda, RTP/FedNow remittance, or wire OBI to be lost.
**Knowledge Base Used:** [Payments, quotes, and transfers API](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/payments-and-quotes-api.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Summary
POST /quotesfor all transfers/transfer-inand/transfer-outendpoint code pathsimmediatelyExecute: trueto combine quote creation and executionThis syncs the Grid Visualizer with the OpenAPI schema changes from #856 which deprecated
/transfer-inand/transfer-outin favor of the unified/quotesendpoint.Areas updated
Grid Visualizer (
components/grid-visualizer/src/lib/code-generator.ts)/quotesAPI calls instead of the deprecated endpointsimmediatelyExecute: truefor a single-request flowDocumentation - Already up to date
Kotlin Sample - Already up to date
/quotesendpoint, not deprecated endpointsTest plan
🤖 Generated with Claude Code