LCORE-4200: Enable ISC rule group on CI

[tisnik]

Description

LCORE-4200: Enable ISC rule group on CI

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library [pyproject.toml + uv.lock]
• Bump-up dependent library [requirements.*.txt for Konflux]
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement
• Benchmarks improvement

Tools used to create PR

• Assisted-by: N/A
• Generated by: N/A

Related Tickets & Documents

• Related Issue #LCORE-4200

Summary by CodeRabbit

• Chores
  • Updated linting settings.
• Style
  • Simplified string formatting without changing displayed token summaries or expected error messages.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: lightspeed-core/lightspeed-stack/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 6f4da042-3729-495f-b184-2ee03bd2b642

📥 Commits

Reviewing files that changed from the base of the PR and between 649e1ad and 4997146.

📒 Files selected for processing (4)

• pyproject.toml
• src/utils/token_counter.py
• tests/unit/models/config/test_cors.py
• tests/unit/utils/test_ogx_version.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (21)

• GitHub Check: E2E: server / ci / tls
• GitHub Check: E2E: server / ci / rbac
• GitHub Check: E2E: library / ci / skills
• GitHub Check: E2E: library / ci / default
• GitHub Check: E2E: server / ci / skills
• GitHub Check: E2E: library / ci / shields
• GitHub Check: E2E: library / ci / rbac
• GitHub Check: E2E: library / ci / other
• GitHub Check: E2E: library / ci / authorized
• GitHub Check: E2E: library / ci / mcp
• GitHub Check: E2E: server / ci / mcp
• GitHub Check: E2E: server / ci / default
• GitHub Check: E2E: server / ci / other
• GitHub Check: E2E: server / ci / authorized
• GitHub Check: E2E: server / ci / shields
• GitHub Check: unit_tests (3.12)
• GitHub Check: integration_tests (3.13)
• GitHub Check: unit_tests (3.13)
• GitHub Check: Pylinter
• GitHub Check: integration_tests (3.12)
• GitHub Check: build-pr

⚠️ CI failures not shown inline (1)

GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request: Failed

Conclusion: failure

View job details

Konflux kflux-prd-rh02/lightspeed-stack-0-8-on-pull-request has <b>failed</b>.
<ul>
<li><b>Namespace</b>: <a href="https://konflux-ui.apps.kflux-prd-rh02.0fk9.p1.openshiftapps.com/ns/lightspeed-core-tenant">lightspeed-core-tenant</a></li>
<li><b>PipelineRun:</b> <a href="https://konflux-ui.apps.kflux-prd-rh02.0fk9.p1.openshiftapps.com/ns/lightspeed-core-tenant/pipelinerun/lightspeed-stack-0-8-on-pull-request-bkq7k">lightspeed-stack-0-8-on-pull-request-bkq7k</a></li>
</ul>
<hr>
<h4>Task Statuses:</h4>
Pipeline lightspeed-core-tenant/lightspeed-stack-0-8-on-pull-request-bkq7k can't be Run; it contains Tasks that don't exist: Couldn't retrieve Task "resolver type bundles\nname = rpms-signature-scan\n": error requesting remote resource: error getting "bundleresolver" "lightspeed-core-tenant/bundles-b06e5c79108f8e7c24c41be20b2f7f79": invalid tekton bundle quay.io/konflux-ci/tekton-catalog/task-rpms-signature-scan:0.2.2@sha256:***REDACTED_HIGH_ENTROPY_STRING***, error: the layer 0 does not contain a dev.tekton.image.apiVersion annotation

🔇 Additional comments (4)

src/utils/token_counter.py (1)

36-39: LGTM!

tests/unit/models/config/test_cors.py (1)

93-94: LGTM!

tests/unit/utils/test_ogx_version.py (1)

65-65: LGTM!

Also applies to: 87-87

pyproject.toml (1)

260-260: 🎯 Functional Correctness

ISC001 remains selected, but the base configuration already selected it explicitly. This change does not introduce the specific selection concern, and the inspected configuration establishes no requirement to exclude the rule.

---

Walkthrough

The Ruff configuration no longer selects ISC001. Explicit concatenation operators were removed from adjacent string literals in TokenCounter.__str__ and test expectations. The formatted text and expected messages remain unchanged.

Changes

String Concatenation Cleanup

Layer / File(s)	Summary
Update concatenation style pyproject.toml, src/utils/token_counter.py, tests/unit/models/config/test_cors.py, tests/unit/utils/test_ogx_version.py	Ruff no longer selects ISC001. The token summary and test expectations use adjacent string literals instead of explicit + operators. Their text remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Suggested reviewers: asimurka

Merge Risk: ⚪ Minimal · up to 49971

The token summary and tested error messages remain unchanged. No actionable merge risk is identified beyond normal checks.

🚥 Pre-merge checks | ✅ 7

✅ Passed checks (7 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the ISC rule group and its CI configuration, which match the stated pull request objective.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (1 skipped: 1 …
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity	✅ Passed	The changes introduce no meaningful performance regression. pyproject.toml expands the Ruff ISC lint selection, and the source and test changes replace explicit string concatenation with adjacent …
Security And Secret Handling	✅ Passed	No security or secret-handling violation was introduced. The PR changes only Ruff lint configuration and replaces explicit string concatenation with adjacent string literals in a token-counter summary…

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Create a new PR

✨ Simplify code

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}