Repository navigation
review: repo-governance - Reconcile locked-file approval [LOCKED-FILES-APPROVAL] #335
Copy link
Copy link
Open
Open
Copy link
Description
Approval Request for Locked Files Changes
This issue reconciles the conditional approval for locked file changes in merged PR build: repo-governance - Align tooling and ownership controls per CLAUDE.md guidelines.
Files Modified (Locked)
- .github/CODEOWNERS - New file establishing code ownership for governance paths
- Sets @ashley as owner for governance-related files
- Implements bug: netlify - Fix unreadable redirects output and validate routing #3 decision from epic: repo-governance - Tailor book repository tooling and governance #237
- .github/BRANCH_PROTECTION_CONFIG.md - Historical proposed path for the branch-protection guide. The delivered file is docs/BRANCH_PROTECTION_CONFIG.md, consistent with the documentation-placement condition.
- Documents manual setup process for branch protection rules
- Supports governance implementation
Decision Context
These changes implement governance decision GH-3 from epic #237:
- Establishes clear code ownership boundaries
- Documents branch protection requirements for main and develop
- Part of broader governance alignment work (NODE-001, TEST-001, STYLE-001, automation: branches - Add report-only branch cleanup #270)
Related PR
- PR build: repo-governance - Align tooling and ownership controls #301:
feat/governance-decisions-implement- Governance alignment work
Validation
Historical reported results, not current revision-specific validation:
- Vite build: reported passing
- Tests: reported 571 passing
- Branch naming: reported valid (
feat/governance-decisions-implement) - Changes are minimal and focused on governance documentation
Approval Decision
Conditional approval was recorded by Ash on 18 October 2026: documentation belongs in the documentation directory rather than directly under the governance directory. PR #301 is merged, and the delivered branch-protection guide follows that placement condition. This does not establish effective repository protection or approve unrelated changes.
Acceptance criteria
- Record the exact approved files and documentation-placement condition
- Reconcile the condition with the merged changes
- Verify the ownership identity and permissions
- Distinguish documented protection requirements from active GitHub settings
- Record unresolved implementation checks and their existing owners
Definition of Ready
- Target changes, related PR and prior approval identified
- Conditional documentation placement recorded
- Remaining verification scope agreed
Definition of Done
- Scoped approval outcome and evidence recorded
- Conditions resolved or explicitly handed off
- Remaining enforcement limitations documented
- No implementation completion inferred from approval alone
Locked Files Approval Request - Generated by Claude Code
Reactions are currently unavailable
Metadata
Metadata
Assignees
Type
Fields
Priority
None yet
Activity
linear-code commentedon Oct 18, 2026
TOA-293
ashleyshaw commentedon Oct 18, 2026
I approve this issue, but I think we need to create docs in
docs/folder not in the root of the.github/folder like the proposed file =.github/BRANCH_PROTECTION_CONFIG.mdrefactor: move BRANCH_PROTECTION_CONFIG to docs/ folder
[-][LOCKED-FILES-APPROVAL] Approve .github CODEOWNERS and BRANCH_PROTECTION_CONFIG changes[/-][+]review: repo-governance - Reconcile locked-file approval [LOCKED-FILES-APPROVAL][/+]