Skip to content

feat: events - Integrate approved event views and route states #379

Open

Description

@ashleyshaw

Outcome

Replace hardcoded placeholders with the approved collection and applicable existing views.

Verified context

Book-site EventsPage.tsx displays placeholder formats; legacy archive/detail components already offer richer behaviour.

Scope

Register only approved destinations and preserve book-first scope.

Acceptance criteria

  • Approved list/detail/taxonomy routes and links resolve; unknown IDs have intentional states.
  • Historical, cancelled/missed and confirmed future participation are distinguishable.
  • Empty guidance is editable and does not imply dates or bookings.
  • Tests cover inclusion, routing and keyboard interaction; public metadata matches displayed events.

Boundaries and sources

Creation defines work only; it does not start implementation. Preserve unrelated code, protected assets, editorial wording and existing records. Do not fabricate content, identity, media, manuscript chapters, dates or engagement data. Use approved repository-native authoring, validation, preview and publication decisions; do not provision an external CMS or database. Existing editorial verification remains with its current issues. All acceptance criteria remain unchecked until evidenced.

Repository evidence was inspected on develop at 4ecdb26d9655a48bf000a7c89da2f70383edce87. Recheck before implementation; no build or browser tests were run for this draft. Follow repository instructions and applicable Spec Kit requirements. Paths below refer to this repository.

Sources: repository instructions, application, editorial content.

Branch instructions

  • Repository: lightspeedwp/ThisOneTimeOnAcidCom
  • Proposed branch: feat/events-view-integration
  • Base: develop
  • Naming policy: local guide, validator, organisation strategy.
  • Pull request template: Organisation .github/PULL_REQUEST_TEMPLATE/pr_feature.md, per inspected local routing; recheck before opening a PR.
  • Constraints: Preserve unrelated changes; do not force-push, merge or deploy. Complete applicable Spec Kit requirements before implementation.
  • Conflicts or missing evidence: Proposed branch, not an existing branch; collision freedom is unverified. Recheck current branch routing and open governance changes, including PR automation: repo-governance - Add governance automation and validation #346. Older instructions claim branch rules are absent; the inspected local guide and executable validator establish the current convention. This draft creates no branch or pull request.

Branch instructions — batch 28 audit addendum

  • Repository: lightspeedwp/ThisOneTimeOnAcidCom; implementing target: this view-integration issue, counterpart GitHub issue 379.
  • Proposed branch: feat/events-view-integration; base: refreshed develop, checked at 4ecdb26d9655a48bf000a7c89da2f70383edce87 (D). Organisation baseline: 8f28eca80bff198879f7aaf496717dc0551bb32e (O).
  • Branch state: proposed new branch, not created/reused. Returned branch/open-PR listings and exact-head search found no match. Refresh before work; reuse requires verified equivalent scope. No automatic reset/rename/reuse of unrelated work.
  • Naming: local guide, validator and organisation strategy authorise feat/type-scope-title. Static inspection only; older no-conventions claims conflict with current files.
  • Template: shared Feature template. Local routing suggests it/attempts a label, not body insertion. Verify selection separately; no sample closing references, automatic frontmatter metadata or locked-template edits.
  • Parent context: preserve hierarchy; omit coordination-parent identifiers/URLs from branches, PR metadata and coding prompts while effects remain unverified. Never use parent as native development/closing target.
  • Allowed closing targets: none for this provisional contribution. Partial work cannot close the issue; future references/associations require separate review.
  • Governance PR346 is context, not delivered infrastructure or reuse branch. No repository edits, branch/PR operations, execution, merge or deployment authorised.

Expected file changes

Provisional view-integration plan. At D, active events index uses the hardcoded book-site page; legacy views use Origin-only mock aggregation. No event loader exists in inspected utils. Applied loading guidance is not delivered code.

Specification-first approval remains prerequisite. Catalogue shows 001/002; allocation unresolved. Preview exact specification/research/plan/tasks paths and catalogue changes separately; no number/path reserved here.

Operation Path Intended change Evidence/revision Approval or dependency
Edit src/app/components/pages/book-site/EventsPage.tsx Approved collection/states instead of placeholders; visible-content/schema agreement D: hardcoded formats, empty CTA and WebPage schema Approved inclusion/narrative/publication and delivered loader
Edit src/app/routes.ts Only approved detail/taxonomy destinations and unknown states D: only index registered Approved route matrix; preserve unrelated routes
Edit, conditional src/app/components/pages/events/EventsPage.tsx; src/app/components/pages/events/EventDetailPage.tsx; src/app/components/pages/events/EventCategoryPage.tsx; src/app/components/pages/events/EventTagPage.tsx Adapt only selected reusable views to approved records; safe absent editions/media D: mock imports, edition assumptions and slug lookups Explicit selected-view/contracts approval; no blanket portfolio restoration
Edit, conditional src/app/data/mock/pages/events.ts; src/app/data/mock/ui/events.ts UI-only empty/error/status labels D: existing page/UI data Approved wording; narrative stays in approved content pipeline
Edit, conditional src/app/data/mock/seo/pages.ts; src/app/data/mock/seo/dynamic.ts Event metadata matching visible approved records D: bookEvents and legacy appearance defaults Public-metadata review; no invented appearances
Create, proposed e2e/events.spec.ts Inclusion, empty/invalid/unknown states, routing, keyboard and metadata consistency D: Playwright e2e discovery/routing precedent; destination proposed Approved controlled fixtures/contracts/browser environment; no harness/dependency changes

No moves/deletions. Event model/loading decisions remain prerequisites; do not guess APIs, dates, editions, bookings, assets or approval. Distinguish historical attendance, cancelled/missed participation and independently confirmed future appearances.

Exclude editorial migration, loader/schema implementation, dependencies/configuration, protected assets/references/fallback component, Supabase, attribution/changelog and managed workflows. Resolve changelog handling separately. Default prompt/report/task writes deferred under draft-only scope. No commands, installs, tests, builds, scripts, hooks or cloud operations performed. Extra paths/material changes require revised preview and approval. Exclude credentials/restricted material from public sync. Description approval changes no status, ownership, labels, hierarchy or PR associations and grants no implementation authority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Fields

Priority

None yet

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions